From: Stefano Brivio <sbrivio@redhat•com>
To: Dmitry Vyukov <dvyukov@google•com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail•com>,
Eric Dumazet <eric.dumazet@gmail•com>,
syzbot <syzbot+4ad25edc7a33e4ab91e0@syzkaller•appspotmail.com>,
David Miller <davem@davemloft•net>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
linux-kernel <linux-kernel@vger•kernel.org>,
Network Development <netdev@vger•kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups•com>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>
Subject: Re: kernel panic: stack is corrupted in udp4_lib_lookup2
Date: Fri, 4 Jan 2019 18:14:24 +0100 [thread overview]
Message-ID: <20190104181424.5ad4b1de@redhat.com> (raw)
In-Reply-To: <CACT4Y+bRLOVCx9Z=vCMspjzGrcnNFqNGWxDwiwYZbw2LTh__FA@mail.gmail.com>
On Fri, 4 Jan 2019 12:05:04 +0100
Dmitry Vyukov <dvyukov@google•com> wrote:
> On Fri, Jan 4, 2019 at 11:54 AM Stefano Brivio <sbrivio@redhat•com> wrote:
> >
> > On Fri, 4 Jan 2019 11:32:12 +0100
> > Dmitry Vyukov <dvyukov@google•com> wrote:
> >
> > > On Thu, Jan 3, 2019 at 10:54 PM Stefano Brivio <sbrivio@redhat•com> wrote:
> > > >
> > > > On Thu, 3 Jan 2019 15:15:06 -0600
> > > > Willem de Bruijn <willemdebruijn.kernel@gmail•com> wrote:
> > > >
> > > > > syzbot generated stack traces with
> > > > >
> > > > > [ 183.517380] udpv6_err+0x46/0x60
> > > > > [ 183.520739] ? __udp6_lib_err+0x1890/0x1890
> > > > > [ 183.525054] gue6_err_proto_handler+0x199/0x280
> > > >
> > > > Where? I can't find that in any logs linked from the dashboard at
> > > > https://syzkaller.appspot.com/bug?extid=4ad25edc7a33e4ab91e0 :(
> > >
> > > Stefano, there are these 4 bugs reported that have similarly looking
> > > reproducers involving udp sockets and that crash modes that looks like
> > > stack corruption/overflow:
> > >
> > > https://syzkaller.appspot.com/bug?extid=14005fa30c9a07192934
> > > https://syzkaller.appspot.com/bug?extid=d14090007dc9ba5fa9b7
> > > https://syzkaller.appspot.com/bug?extid=137ed32ec9a6d5b0d5fe
> > > https://syzkaller.appspot.com/bug?id=d5bc3e0c66d200d72216ab343a67c4327e4a3452
> > >
> > > Are these the same bug as this?
> >
> > Judging from the reproducers for the first three, they seem to be.
>
> OK, then I will mark them as dups of this one.
syzbot just finished the tests I requested and couldn't reproduce the
first three issues with the fix I posted (fou6: Prevent unbounded
recursion in GUE error handler).
This should prove they are in fact the same issue.
> > I
> > guess I can trigger tests also for those by sending a (sharp)syz
> > test ... e-mail with the patch to the Reported-by: addresses, right?
>
> Correct.
> These should be on LKML, but as you noted you can just add the syzbot
> email with tag to TO/CC. That email is available in the Reported-by
> tag (and also shown on the dashboard).
Okay, thanks for confirming.
> > And the three reports you pointed out from the pile of corrupted
> > reports also seem to match, others look unrelated.
>
> I've added these as tests:
>
> https://github.com/google/syzkaller/blob/master/pkg/report/testdata/linux/report/341
> https://github.com/google/syzkaller/blob/master/pkg/report/testdata/linux/report/342
> https://github.com/google/syzkaller/blob/master/pkg/report/testdata/linux/report/343
> https://github.com/google/syzkaller/blob/master/pkg/report/testdata/linux/report/344
>
> Will try to figure out how to distinguish them from true corrupted
> reports. Usually when Call Trace does not have any frames, it's a sign
> of a corrupted report, and in other crashes we see the same report but
> with a stack trace. But some stack-corruption-related reliably don't
> have stack traces (not corrupted). But then some other
> stack-corruption-related crashes do have stack traces, and for these
> no stack trace again means a corrupted kernel output. Amusingly this
> is one of the most complex parts of syzkaller.
I'm not sure how complicated that would be, but what about some metric
based on valid symbol names being reported?
--
Stefano
next prev parent reply other threads:[~2019-01-04 17:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 13:07 kernel panic: stack is corrupted in udp4_lib_lookup2 syzbot
2019-01-03 19:39 ` Willem de Bruijn
2019-01-03 19:41 ` Willem de Bruijn
2019-01-03 20:00 ` Stefano Brivio
2019-01-03 20:01 ` Eric Dumazet
2019-01-03 20:07 ` Stefano Brivio
2019-01-03 21:15 ` Willem de Bruijn
2019-01-03 21:54 ` Stefano Brivio
2019-01-04 10:32 ` Dmitry Vyukov
2019-01-04 10:34 ` Dmitry Vyukov
2019-01-04 10:54 ` Stefano Brivio
2019-01-04 11:05 ` Dmitry Vyukov
2019-01-04 17:14 ` Stefano Brivio [this message]
2019-01-04 17:24 ` Willem de Bruijn
2019-01-04 17:50 ` Stefano Brivio
2019-01-04 17:26 ` Dmitry Vyukov
2019-01-04 18:05 ` Stefano Brivio
2019-01-07 9:04 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104181424.5ad4b1de@redhat.com \
--to=sbrivio@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dvyukov@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=syzbot+4ad25edc7a33e4ab91e0@syzkaller$(echo .)appspotmail.com \
--cc=syzkaller-bugs@googlegroups$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox