Subject: Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031

From: Tony Lindgren <[email-masked]>
Date: Thu, 10 Jan 2019 13:24:46 -0800

* Heiner Kallweit <[email-masked]> [190110 19:22]:
> So far genphy_soft_reset was used automatically if the PHY driver
> didn't implement the soft_reset callback. This changed with the
> mentioned commit and broke KSZ9031. To fix this configure the
> KSZ9031 PHY driver to use genphy_soft_reset.
> 
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Reported-by: Tony Lindgren <[email-masked]>
> Signed-off-by: Heiner Kallweit <[email-masked]>

Thanks this fixes the regression for me:

Tested-by: Tony Lindgren <[email-masked]>

> ---
>  drivers/net/phy/micrel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index c33384710..7828d17f0 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = {
>  	.driver_data	= &ksz9021_type,
>  	.probe		= kszphy_probe,
>  	.config_init	= ksz9031_config_init,
> +	.soft_reset	= genphy_soft_reset,
>  	.read_status	= ksz9031_read_status,
>  	.ack_interrupt	= kszphy_ack_interrupt,
>  	.config_intr	= kszphy_config_intr,
> -- 
> 2.20.1
>