public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Andrew Lunn <andrew@lunn•ch>
To: Samu Nuutamo <samu.nuutamo@vincit•fi>
Cc: netdev@vger•kernel.org, Vivien Didelot <vivien.didelot@gmail•com>,
	Florian Fainelli <f.fainelli@gmail•com>,
	"David S. Miller" <davem@davemloft•net>
Subject: Re: Regression: mv88e6xxx packet loss after 4.18's PHYLINK merge
Date: Mon, 14 Jan 2019 15:23:58 +0100	[thread overview]
Message-ID: <20190114142358.GJ4635@lunn.ch> (raw)
In-Reply-To: <20190114113444.GB16632@samu-ThinkPad-T480s>

On Mon, Jan 14, 2019 at 01:34:44PM +0200, Samu Nuutamo wrote:
> Hi,
> 
> We have an imx6q-b450v3 board that has one of the switch ports configured as a
> fixed link. After upgrading the kernel to version 4.18 the link has experienced
> a small amount of packet loss, around 0.15%.
> 
> The issue was bisected to a commit: aab9c4067d23 net: dsa: Plug in PHYLINK support
> 
> After enabling debug we could see that the new phylink code causes the link to
> reset once every second:
> 
> [  309.992368] mv88e6085 gpio-0:00 enembc: phylink_mac_config: mode=fixed//100Mbps/Full adv=00000,00000208 pause=10 link=1 an=1
> [  309.998451] mv88e6085 gpio-0:00: p5: Force link down
> [  309.998869] mv88e6085 gpio-0:00: p5: Speed set to 100 Mbps
> [  309.999280] mv88e6085 gpio-0:00: p5: Force full duplex
> [  309.999895] mv88e6085 gpio-0:00: p5: Force link up
> [  311.032400] mv88e6085 gpio-0:00 enembc: phylink_mac_config: mode=fixed//100Mbps/Full adv=00000,00000208 pause=10 link=1 an=1
> [  311.038248] mv88e6085 gpio-0:00: p5: Force link down
> [  311.038660] mv88e6085 gpio-0:00: p5: Speed set to 100 Mbps
> [  311.039069] mv88e6085 gpio-0:00: p5: Force full duplex
> [  311.039678] mv88e6085 gpio-0:00: p5: Force link up
> [  312.072328] mv88e6085 gpio-0:00 enembc: phylink_mac_config: mode=fixed//100Mbps/Full adv=00000,00000208 pause=10 link=1 an=1
> [  312.077603] mv88e6085 gpio-0:00: p5: Force link down
> [  312.078010] mv88e6085 gpio-0:00: p5: Speed set to 100 Mbps
> [  312.078417] mv88e6085 gpio-0:00: p5: Force full duplex
> [  312.079026] mv88e6085 gpio-0:00: p5: Force link up

Hi Samu

Thanks for the report.

I think we should be fixing this from the other end. Why does PHYLINK
reset the link once per second? If you have time, please could you
investigate that.

	    Thanks
		Andrew

next prev parent reply	other threads:[~2019-01-14 14:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 11:34 Regression: mv88e6xxx packet loss after 4.18's PHYLINK merge Samu Nuutamo
2019-01-14 14:23 ` Andrew Lunn [this message]
2019-01-14 18:03   ` Florian Fainelli
2019-01-15  8:15     ` Samu Nuutamo
2019-01-17  2:29 ` Andrew Lunn
2019-01-17 11:37   ` Samu Nuutamo
2019-01-23  2:10     ` Andrew Lunn
2019-01-23  7:16       ` Samu Nuutamo
2019-01-25 19:00       ` Florian Fainelli
2019-01-25 19:15         ` Russell King - ARM Linux admin
2019-01-17 15:46   ` Samu Nuutamo
2019-01-21 17:52     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114142358.GJ4635@lunn.ch \
    --to=andrew@lunn$(echo .)ch \
    --cc=davem@davemloft$(echo .)net \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=samu.nuutamo@vincit$(echo .)fi \
    --cc=vivien.didelot@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox