Subject: Re: [RFC iproute2-next] devlink: add info subcommand

From: Andrew Lunn <[email-masked]>
Date: Tue, 15 Jan 2019 15:00:46 +0100

On Tue, Jan 15, 2019 at 09:20:11AM +0100, Jiri Pirko wrote:
> [...]
> 
> > static void help(void)
> > {
> > 	pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n"
> > 	       "       devlink [ -f[orce] ] -b[atch] filename\n"
> >-	       "where  OBJECT := { dev | port | sb | monitor | dpipe | resource | region }\n"
> >+	       "where  OBJECT := { dev | port | sb | monitor | dpipe | resource | region | info }\n"
> 
> I think that "info" should be nested under "dev". It is related to dev.
> Maybe it even does not have to be a separate command and can be a nested
> attribute to existing DEVLINK_CMD_GET cmd.

Hi Jiri

Not that i agree devlink is the right place for this, but i think it
probably needs to be nested both under dev and port. I could have a
line card implementing a port which has version information, as well
as version information for the backplane which would be under dev.

   Andrew