From: Andrew Lunn <andrew@lunn•ch>
To: Heiner Kallweit <hkallweit1@gmail•com>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] net: phy: don't include asm/irq.h directly
Date: Tue, 15 Jan 2019 22:29:51 +0100 [thread overview]
Message-ID: <20190115212951.GB26788@lunn.ch> (raw)
In-Reply-To: <b45a616c-2ade-5823-e5da-bcd14b25d7ae@gmail.com>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 189cd2048..f95753eda 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -36,8 +36,6 @@
> #include <linux/uaccess.h>
> #include <linux/atomic.h>
>
> -#include <asm/irq.h>
> -
Hi Heiner
There is a call to request_threaded_irq() and free_irq() in this
file. So it should probably include linux/irq.h.
Andrew
next prev parent reply other threads:[~2019-01-15 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 20:40 [PATCH net-next] net: phy: don't include asm/irq.h directly Heiner Kallweit
2019-01-15 21:29 ` Andrew Lunn [this message]
2019-01-15 21:33 ` Heiner Kallweit
2019-01-15 21:46 ` Andrew Lunn
2019-01-15 22:31 ` Florian Fainelli
2019-01-17 5:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115212951.GB26788@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox