Subject: Re: [PATCH] net: phy: mdio_bus: add missing device_del() in mdiobus_register() error handling

From: Andrew Lunn <[email-masked]>
Date: Wed, 16 Jan 2019 15:48:29 +0100

> The actual error that we had from devm_gpiod_get_optional() was
> -EPROBE_DEFER, due to the GPIO being provided by a driver that is
> probed later than the Ethernet controller driver.
> 
> To fix this, we simply add the missing device_del() invocation in the
> error path.

Hi Thomas

Reviewed-by: Andrew Lunn <[email-masked]>

However, i wounder if it makes sense to add a label before the
existing device_del() at the end of the function, and convert this,
and the case above into a goto? That might scale better, avoiding the
same issue in the future?

Thanks

    Andrew