Subject: Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

From: Dan Carpenter <[email-masked]>
Date: Thu, 17 Jan 2019 11:38:04 +0300

No need to send this as an RFC patch.  Adding a new driver is
normal and uncontroversial.

On Wed, Jan 16, 2019 at 07:24:22PM -0800, [email-masked] wrote:
> +
> +	i2c_set_clientdata(i2c, dev);
                                ^^^
> +
> +	return 0;
> +}
> +
> +static int ksz9477_i2c_remove(struct i2c_client *i2c)
> +{
> +	struct ksz_device *dev = i2c_get_clientdata(i2c);
> +
> +	if (dev)
            ^^^
No need.

> +		ksz_switch_remove(dev);
> +
> +	return 0;
> +}
> +

regards,
dan carpenter