Subject: Re: [PATCH net-next] virtio_net: bulk free tx skbs

From: "Michael S. Tsirkin" <[email-masked]>
Date: Thu, 17 Jan 2019 08:34:56 -0500

On Wed, Jan 16, 2019 at 03:31:58PM -0800, David Miller wrote:
> From: "Michael S. Tsirkin" <[email-masked]>
> Date: Mon, 14 Jan 2019 20:34:26 -0500
> 
> > Use napi_consume_skb() to get bulk free.  Note that napi_consume_skb is
> > safe to call in a non-napi context as long as the napi_budget flag is
> > correct.
> > 
> > Signed-off-by: Michael S. Tsirkin <[email-masked]>
> > ---
> > 
> > My perf testing setup is down but it works fine on my devel box and
> > should be fairly uncontroversial.
> 
> It would be uncontroversial if it compiled.
> 
> drivers/net/virtio_net.c: In function ‘free_old_xmit_skbs’:
> drivers/net/virtio_net.c:1346:25: error: ‘use_napi’ undeclared (first use in this function); did you mean ‘used_math’?
>    napi_consume_skb(skb, use_napi);
>                          ^~~~~~~~
>                          used_math
> drivers/net/virtio_net.c:1346:25: note: each undeclared identifier is reported only once for each function it appears in

Yes my bad it was on top of other patches.
I'm rebasing and will repost.

-- 
MST