Subject: Re: [PATCH net-next v2 2/4] net: phy: warn if phy_start is called from invalid state

From: Andrew Lunn <[email-masked]>
Date: Mon, 21 Jan 2019 19:29:28 +0100

> For all invalid states phy_start() basically was a no-op. All it did was
> triggering a state machine run, but for all "running" states the poll
> loop was active anyway. And if called from PHY_DOWN, the state machine
> does nothing. Therefore I see no scenario where jumping to out would
> break anything.

Hi Heiner

It is useful to put this sort of analysis in the commit message. You
then won't get people like me asking about it.

     Andrew