From: Andrew Lunn <andrew@lunn•ch>
To: Heiner Kallweit <hkallweit1@gmail•com>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH 4/4 net-next] net: phy: aquantia: replace magic numbers with constants
Date: Sun, 3 Feb 2019 20:56:44 +0100 [thread overview]
Message-ID: <20190203195644.GG27045@lunn.ch> (raw)
In-Reply-To: <12255e2f-24ca-6e94-f7d0-25ba4dfa216f@gmail.com>
On Sun, Feb 03, 2019 at 08:35:54PM +0100, Heiner Kallweit wrote:
> Replace magic numbers with proper constants. The original patch is
> from Andrew, I extended / adjusted certain parts:
> - Use decimal bit numbers. The datasheet uses hex bit numbers 0 .. F.
> - Order defines from highest to lowest bit numbers
> - correct some typos
> - add constant MDIO_AN_TX_VEND_INT_MASK2_LINK
> - Remove few functional improvements from the patch, they will come as
> a separate patch.
>
> Signed-off-by: Andrew Lunn <andrew@lunn•ch>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail•com>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
prev parent reply other threads:[~2019-02-03 19:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 19:32 [PATCH 0/4 net-next] net: phy: aquantia: number of improvements Heiner Kallweit
2019-02-03 19:33 ` [PATCH 1/4 net-next] net: phy: aquantia: shorten name space prefix to aqr_ Heiner Kallweit
2019-02-03 19:38 ` Andrew Lunn
2019-02-03 19:42 ` Heiner Kallweit
2019-02-03 19:33 ` [PATCH 2/4 net-next] net: phy: aquantia: remove unneeded includes Heiner Kallweit
2019-02-03 19:54 ` Andrew Lunn
2019-02-03 20:08 ` Heiner Kallweit
2019-02-03 19:34 ` [PATCH 3/4 net-next] net: phy: aquantia: use macro PHY_ID_MATCH_MODEL Heiner Kallweit
2019-02-03 19:54 ` Andrew Lunn
2019-02-03 19:35 ` [PATCH 4/4 net-next] net: phy: aquantia: replace magic numbers with constants Heiner Kallweit
2019-02-03 19:56 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190203195644.GG27045@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox