Subject: Re: [PATCH net-next 5/6] net: marvell: neta: add comphy support

From: Maxime Chevallier <[email-masked]>
Date: Wed, 6 Feb 2019 16:09:28 +0100

Hello Russell,

On Wed, 06 Feb 2019 11:35:07 +0000
Russell King <[email-masked]> wrote:

>+	if (pp->comphy) {
>+		enum phy_mode mode = PHY_MODE_INVALID;
>+
>+		switch (state->interface) {
>+		case PHY_INTERFACE_MODE_SGMII:
>+		case PHY_INTERFACE_MODE_1000BASEX:
>+			mode = PHY_MODE_SGMII;

PHY_MODE_SGMII no longer exists, the new PHY_MODE_ETHERNET must be used
with the correct submode now, so this doesn't build unfortunately.

>+			break;
>+		case PHY_INTERFACE_MODE_2500BASEX:
>+			mode = PHY_MODE_2500SGMII;

Same here.

Thanks,

Maxime