From: Andrew Lunn <andrew@lunn•ch>
To: Tristram.Ha@microchip•com
Cc: Sergio Paracuellos <sergio.paracuellos@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Pavel Machek <pavel@ucw•cz>,
UNGLinuxDriver@microchip•com, netdev@vger•kernel.org
Subject: Re: [PATCH v1 net-next 3/4] net: dsa: microchip: use readx_poll_time for polling
Date: Sat, 9 Feb 2019 18:01:20 +0100 [thread overview]
Message-ID: <20190209170120.GE30856@lunn.ch> (raw)
In-Reply-To: <1549598829-25970-4-git-send-email-Tristram.Ha@microchip.com>
On Thu, Feb 07, 2019 at 08:07:08PM -0800, Tristram.Ha@microchip•com wrote:
> From: Tristram Ha <Tristram.Ha@microchip•com>
>
> Replace register polling functions using timeout with readx_poll_time call.
>
> Signed-off-by: Tristram Ha <Tristram.Ha@microchip•com>
> ---
> drivers/net/dsa/microchip/ksz9477.c | 91 +++++++++++--------------------------
> 1 file changed, 27 insertions(+), 64 deletions(-)
>
> diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c
> index 4502e13..8391b9e 100644
> --- a/drivers/net/dsa/microchip/ksz9477.c
> +++ b/drivers/net/dsa/microchip/ksz9477.c
> @@ -114,28 +114,11 @@ static void ksz9477_port_cfg32(struct ksz_device *dev, int port, int offset,
> data; \
> })
>
> -static int ksz9477_wait_vlan_ctrl_ready(struct ksz_device *dev, u32 waiton,
> - int timeout)
> -{
> - u8 data;
> -
> - do {
> - ksz_read8(dev, REG_SW_VLAN_CTRL, &data);
> - if (!(data & waiton))
> - break;
> - usleep_range(1, 10);
> - } while (timeout-- > 0);
> -
> - if (timeout <= 0)
> - return -ETIMEDOUT;
> -
> - return 0;
Hi Tristram
I think it would be better to keep ksz9477_wait_vlan_ctrl_ready(),
ksz9477_wait_alu_ready() etc, and change there implementation to use
readx_poll_timeout(). The function names act as better documentation
for what we are waiting for than the parameters being passed to
readx_poll_timeout().
Andrew
next prev parent reply other threads:[~2019-02-09 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 4:07 [PATCH v1 net-next 0/4] net: dsa: microchip: add MIB counters support Tristram.Ha
2019-02-08 4:07 ` [PATCH v1 net-next 1/4] net: dsa: microchip: prepare PHY for proper advertisement Tristram.Ha
2019-02-09 16:54 ` Andrew Lunn
2019-02-08 4:07 ` [PATCH v1 net-next 2/4] net: dsa: microchip: add MIB counter reading support Tristram.Ha
2019-02-09 17:22 ` Andrew Lunn
2019-02-13 2:39 ` Tristram.Ha
2019-02-13 3:28 ` Andrew Lunn
2019-02-13 3:51 ` Florian Fainelli
2019-02-14 19:26 ` Tristram.Ha
2019-02-14 19:33 ` Florian Fainelli
2019-02-20 23:49 ` Joe Perches
2019-02-25 18:34 ` Pavel Machek
2019-02-08 4:07 ` [PATCH v1 net-next 3/4] net: dsa: microchip: use readx_poll_time for polling Tristram.Ha
2019-02-09 17:01 ` Andrew Lunn [this message]
2019-02-13 2:53 ` Tristram.Ha
2019-02-08 4:07 ` [PATCH v1 net-next 4/4] net: dsa: microchip: remove unnecessary include headers Tristram.Ha
2019-02-09 17:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209170120.GE30856@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Tristram.Ha@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel@ucw$(echo .)cz \
--cc=sergio.paracuellos@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox