Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy()

From: Andrew Lunn <[email-masked]>
Date: Tue, 19 Feb 2019 18:46:42 +0100

> >  	for (i=1; i<2; i++) {
> 
> 
> the loop here seems also pointless, so you can eliminate i.
> (or did i muss something ?)

If you widen out your view a bit, you find all this code is inside a
#ifdef PHY_CODE_IS_FINISHED. I don't see anything which actually
defines that.

So a lot more code could probably be removed.

   Andrew