From: Andrew Lunn <andrew@lunn•ch>
To: Vinod Koul <vkoul@kernel•org>
Cc: "David S. Miller" <davem@davemloft•net>,
linux-arm-msm@vger•kernel.org,
Bjorn Andersson <bjorn.andersson@linaro•org>,
Xiaofei Shen <xiaofeis@codeaurora•org>,
Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Niklas Cassel <niklas.cassel@linaro•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH] net: dsa: Inherit dev addr from master
Date: Fri, 22 Feb 2019 15:30:03 +0100 [thread overview]
Message-ID: <20190222143003.GL5653@lunn.ch> (raw)
In-Reply-To: <20190222125654.12478-1-vkoul@kernel.org>
On Fri, Feb 22, 2019 at 06:26:54PM +0530, Vinod Koul wrote:
> From: Xiaofei Shen <xiaofeis@codeaurora•org>
>
> When we create slave netdevice, the dev addr is inherited from master
> but the master dev addr maybe NULL at that time, so inherit it again
> while opening the slave.
Hi Xiaofei, Vinod
Inheriting it twice seems a bit clumsy. Can the first inherit be
removed? Can you change your MAC driver to set its MAC address in
probe?
Andrew
next prev parent reply other threads:[~2019-02-22 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 12:56 [PATCH] net: dsa: Inherit dev addr from master Vinod Koul
2019-02-22 14:30 ` Andrew Lunn [this message]
2019-02-25 13:13 ` xiaofeis
2019-02-25 13:21 ` Andrew Lunn
2019-03-27 4:09 ` xiaofeis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222143003.GL5653@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=niklas.cassel@linaro$(echo .)org \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vkoul@kernel$(echo .)org \
--cc=xiaofeis@codeaurora$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox