From: Leon Romanovsky <leon@kernel•org>
To: Steve Wise <swise@opengridcomputing•com>
Cc: 'David Ahern' <dsahern@gmail•com>,
'netdev' <netdev@vger•kernel.org>,
'RDMA mailing list' <linux-rdma@vger•kernel.org>,
'Stephen Hemminger' <stephen@networkplumber•org>
Subject: Re: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file
Date: Sat, 23 Feb 2019 11:05:28 +0200 [thread overview]
Message-ID: <20190223090528.GL23561@mtr-leonro.mtl.com> (raw)
In-Reply-To: <01d601d4ca22$28f83140$7ae893c0$@opengridcomputing.com>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Thu, Feb 21, 2019 at 02:15:16PM -0600, Steve Wise wrote:
>
>
> > -----Original Message-----
> > From: linux-rdma-owner@vger•kernel.org <linux-rdma-
> > owner@vger•kernel.org> On Behalf Of Leon Romanovsky
> > Sent: Wednesday, February 20, 2019 1:21 AM
> > To: David Ahern <dsahern@gmail•com>
> > Cc: Leon Romanovsky <leonro@mellanox•com>; netdev
> > <netdev@vger•kernel.org>; RDMA mailing list <linux-
> > rdma@vger•kernel.org>; Stephen Hemminger
> > <stephen@networkplumber•org>
> > Subject: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to
> > separate file
> >
> > From: Leon Romanovsky <leonro@mellanox•com>
> >
> > Logically separate resource PD logic to separate file,
> > in order to make PD specific logic self-contained.
> >
> > Signed-off-by: Leon Romanovsky <leonro@mellanox•com>
> > ---
>
> Why does it need to be self contained?
The main res.c file was so large that at least for me wasn't clear
how and what to refactor. Such separation allowed me to start code
cleanup by identification of duplicate places.
>
> Reviewed-by: Steve Wise <swise@opengridcomputing•com>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2019-02-23 9:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 7:21 [PATCH iproute2-next v1 00/19] Export object IDs to users Leon Romanovsky
2019-02-20 7:21 ` [PATCH iproute2-next v1 01/19] rdma: update uapi headers Leon Romanovsky
2019-02-21 20:02 ` Steve Wise
2019-02-21 22:11 ` Leon Romanovsky
2019-02-20 7:21 ` [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print code Leon Romanovsky
2019-02-21 15:23 ` David Ahern
2019-02-21 15:39 ` Leon Romanovsky
2019-02-21 20:04 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 03/19] rdma: Provide unique indexes for all visible objects Leon Romanovsky
2019-02-21 20:08 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 04/19] rdma: Provide parent context index for all objects except CM_ID Leon Romanovsky
2019-02-21 20:12 ` Steve Wise
2019-02-23 9:03 ` Leon Romanovsky
2019-02-20 7:21 ` [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file Leon Romanovsky
2019-02-21 20:15 ` Steve Wise
2019-02-23 9:05 ` Leon Romanovsky [this message]
2019-02-20 7:21 ` [PATCH iproute2-next v1 06/19] rdma: Refactor out resource MR " Leon Romanovsky
2019-02-21 20:15 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 07/19] rdma: Move out resource CQ " Leon Romanovsky
2019-02-21 20:16 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 08/19] rdma: Move out resource CM-ID " Leon Romanovsky
2019-02-21 20:17 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 09/19] rdma: Move resource PD " Leon Romanovsky
2019-02-21 20:21 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 10/19] rdma: Properly mark RDMAtool license Leon Romanovsky
2019-02-21 20:22 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 11/19] rdma: Simplify code to reuse existing functions Leon Romanovsky
2019-02-21 20:23 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 12/19] rdma: Simplify CM_ID print code Leon Romanovsky
2019-02-21 20:26 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 13/19] rdma: Refactor CQ prints Leon Romanovsky
2019-02-21 20:27 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 14/19] rdma: Separate MR code Leon Romanovsky
2019-02-21 20:28 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 15/19] rdma: Separate PD code Leon Romanovsky
2019-02-21 20:29 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 16/19] rdma: Move QP code to separate function Leon Romanovsky
2019-02-21 20:29 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 17/19] rdma: Unify netlink attribute checks prior to prints Leon Romanovsky
2019-02-21 20:31 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 18/19] rdma: Perform single .doit call to query specific objects Leon Romanovsky
2019-02-21 20:35 ` Steve Wise
2019-02-20 7:21 ` [PATCH iproute2-next v1 19/19] rdma: Provide and reuse filter functions Leon Romanovsky
2019-02-21 20:39 ` Steve Wise
2019-02-21 15:26 ` [PATCH iproute2-next v1 00/19] Export object IDs to users David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223090528.GL23561@mtr-leonro.mtl.com \
--to=leon@kernel$(echo .)org \
--cc=dsahern@gmail$(echo .)com \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=swise@opengridcomputing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox