From: Andrew Lunn <andrew@lunn•ch>
To: Parshuram Raju Thombare <pthombar@cadence•com>
Cc: "nicolas.ferre@microchip•com" <nicolas.ferre@microchip•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"f.fainelli@gmail•com" <f.fainelli@gmail•com>,
"hkallweit1@gmail•com" <hkallweit1@gmail•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Rafal Ciepiela <rafalc@cadence•com>,
Piotr Sroka <piotrs@cadence•com>, Jan Kotas <jank@cadence•com>
Subject: Re: [PATCH 2/3] net: ethernet: add c45 PHY support in MDIO read/write functions.
Date: Sat, 23 Feb 2019 16:23:04 +0100 [thread overview]
Message-ID: <20190223152304.GD10693@lunn.ch> (raw)
In-Reply-To: <CO2PR07MB2469D90FD13642D668F8D281C1780@CO2PR07MB2469.namprd07.prod.outlook.com>
> >On Fri, Feb 22, 2019 at 08:12:42PM +0000, Parshuram Thombare wrote:
> >> This patch modify MDIO read/write functions to support communication
> >> with C45 PHY in Cadence ethernet controller driver.
> >
> >Hi Parshuram
> >
> >Are all versions of the MDIO controller capable of doing C45?
> >
> > Andrew
> Now driver support c22 and c45 PHY.
> Are you suggesting to add check for C45 PHY using is_c45 in phydev ?
You are unconditionally supporting C45. Are there versions of the
hardware which don't actually support C45? You have this endless loop:
+ /* wait for end of transfer */
+ while (!MACB_BFEXT(IDLE, macb_readl(bp, NSR)))
+ cpu_relax();
If there is hardware which does not support C45, will this loop
forever?
Andrew
next prev parent reply other threads:[~2019-02-23 15:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 20:12 [PATCH 2/3] net: ethernet: add c45 PHY support in MDIO read/write functions Parshuram Thombare
2019-02-22 21:41 ` Andrew Lunn
2019-02-23 6:27 ` Parshuram Raju Thombare
2019-02-23 15:23 ` Andrew Lunn [this message]
2019-02-25 8:18 ` Parshuram Raju Thombare
2019-02-23 15:25 ` Andrew Lunn
2019-02-25 8:19 ` Parshuram Raju Thombare
2019-03-18 17:42 ` [PATCH v2 2/3] net: ethernet: cadence: " Parshuram Thombare
2019-03-18 17:45 ` Florian Fainelli
2019-03-18 17:49 ` Parshuram Raju Thombare
2019-03-21 14:12 ` Nicolas.Ferre
2019-03-23 4:15 ` Parshuram Raju Thombare
2019-03-21 14:25 ` Andrew Lunn
2019-03-23 4:19 ` Parshuram Raju Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223152304.GD10693@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jank@cadence$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=piotrs@cadence$(echo .)com \
--cc=pthombar@cadence$(echo .)com \
--cc=rafalc@cadence$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox