From: "Paul E. McKenney" <paulmck@linux•ibm.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes•org>
Cc: linux-kernel@vger•kernel.org, Alexei Starovoitov <ast@kernel•org>,
Christian Brauner <christian@brauner•io>,
Daniel Borkmann <daniel@iogearbox•net>,
David Ahern <dsahern@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Ingo Molnar <mingo@redhat•com>,
Jakub Kicinski <jakub.kicinski@netronome•com>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
Jesper Dangaard Brouer <hawk@kernel•org>,
John Fastabend <john.fastabend@gmail•com>,
Josh Triplett <josh@joshtriplett•org>,
keescook@chromium•org, kernel-hardening@lists•openwall.com,
kernel-team@android•com, Kirill Tkhai <ktkhai@virtuozzo•com>,
Lai Jiangshan <jiangshanlai@gmail•com>,
Martin KaFai Lau <kafai@fb•com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios•com>,
netdev@vger•kernel.org, Peter Zijlstra <peterz@infradead•org>,
Quentin Perret <quentin.perret@arm•com>,
rcu@vger•kernel.org, Song Liu <songliubraving@fb•com>,
Steven Rostedt <rostedt@goodmis•org>,
Vincent Guittot <vincent.guittot@linaro•org>,
xdp-newbies@vger•kernel.org, Yonghong Song <yhs@fb•com>
Subject: Re: [PATCH v2 6/6] sched: Annotate perf_domain pointer with __rcu
Date: Mon, 25 Feb 2019 13:12:50 -0800 [thread overview]
Message-ID: <20190225211250.GA4072@linux.ibm.com> (raw)
In-Reply-To: <20190223063434.6793-7-joel@joelfernandes.org>
On Sat, Feb 23, 2019 at 01:34:34AM -0500, Joel Fernandes (Google) wrote:
> This fixes the following sparse errors in sched/fair.c:
>
> fair.c:6506:14: error: incompatible types in comparison expression
> fair.c:8642:21: error: incompatible types in comparison expression
>
> Using __rcu will also help sparse catch any future bugs.
>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes•org>
From an RCU perspective:
Reviewed-by: Paul E. McKenney <paulmck@linux•ibm.com>
> ---
> kernel/sched/sched.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index ca6a79f57e7a..c8e6514433a9 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -780,7 +780,7 @@ struct root_domain {
> * NULL-terminated list of performance domains intersecting with the
> * CPUs of the rd. Protected by RCU.
> */
> - struct perf_domain *pd;
> + struct perf_domain __rcu *pd;
> };
>
> extern struct root_domain def_root_domain;
> --
> 2.21.0.rc0.258.g878e2cd30e-goog
>
prev parent reply other threads:[~2019-02-25 21:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 6:34 [PATCH v2 0/6] RCU fixes for rcu_assign_pointer() usage Joel Fernandes (Google)
2019-02-23 6:34 ` [PATCH v2 1/6] net: rtnetlink: Fix incorrect RCU API usage Joel Fernandes (Google)
2019-02-25 21:05 ` Paul E. McKenney
2019-02-23 6:34 ` [PATCH v2 2/6] ixgbe: " Joel Fernandes (Google)
2019-02-25 21:09 ` Paul E. McKenney
2019-02-23 6:34 ` [PATCH v2 3/6] sched/cpufreq: Annotate cpufreq_update_util_data pointer with __rcu Joel Fernandes (Google)
2019-02-25 21:10 ` Paul E. McKenney
2019-02-27 15:42 ` Joel Fernandes
2019-02-23 6:34 ` [PATCH v2 4/6] sched_domain: Annotate RCU pointers properly Joel Fernandes (Google)
2019-02-25 21:11 ` Paul E. McKenney
2019-02-23 6:34 ` [PATCH v2 5/6] rcuwait: Annotate task_struct with __rcu Joel Fernandes (Google)
2019-02-25 21:11 ` Paul E. McKenney
2019-02-23 6:34 ` [PATCH v2 6/6] sched: Annotate perf_domain pointer " Joel Fernandes (Google)
2019-02-25 21:12 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225211250.GA4072@linux.ibm.com \
--to=paulmck@linux$(echo .)ibm.com \
--cc=ast@kernel$(echo .)org \
--cc=christian@brauner$(echo .)io \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jiangshanlai@gmail$(echo .)com \
--cc=joel@joelfernandes$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=kafai@fb$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-hardening@lists$(echo .)openwall.com \
--cc=kernel-team@android$(echo .)com \
--cc=ktkhai@virtuozzo$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=quentin.perret@arm$(echo .)com \
--cc=rcu@vger$(echo .)kernel.org \
--cc=rostedt@goodmis$(echo .)org \
--cc=songliubraving@fb$(echo .)com \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=xdp-newbies@vger$(echo .)kernel.org \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox