From: kbuild test robot <lkp@intel•com>
To: Leandro Dorileo <leandro.maciel.dorileo@intel•com>
Cc: kbuild-all@01•org, netdev@vger•kernel.org,
Jamal Hadi Salim <jhs@mojatatu•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Jiri Pirko <jiri@resnulli•us>,
"David S . Miller" <davem@davemloft•net>,
Vinicius Costa Gomes <vinicius.gomes@intel•com>
Subject: Re: [PATCH net V3 1/2] net/sched: taprio: fix picos_per_byte miscalculation
Date: Sat, 16 Mar 2019 17:00:27 +0800 [thread overview]
Message-ID: <201903161623.W06XxgoT%lkp@intel.com> (raw)
In-Reply-To: <20190315211626.300-2-leandro.maciel.dorileo@intel.com>
[-- Attachment #1: Type: text/plain, Size: 4306 bytes --]
Hi Leandro,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Leandro-Dorileo/net-sched-taprio-cbs-Fix-using-invalid-link-speed/20190316-161006
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=riscv
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:15,
from include/asm-generic/bug.h:18,
from arch/riscv/include/asm/bug.h:75,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from net/sched/sch_taprio.c:10:
net/sched/sch_taprio.c: In function 'taprio_set_picos_per_byte':
>> include/linux/kern_levels.h:5:18: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'long int' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^~~~~~
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
include/linux/printk.h:309:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
net/sched/sch_taprio.c:600:2: note: in expansion of macro 'pr_info'
pr_info("taprio: set %s's picos_per_byte to: %lld, linkspeed: %d\n",
^~~~~~~
net/sched/sch_taprio.c:600:50: note: format string is defined here
pr_info("taprio: set %s's picos_per_byte to: %lld, linkspeed: %d\n",
~~~^
%ld
--
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:15,
from include/asm-generic/bug.h:18,
from arch/riscv/include/asm/bug.h:75,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from net//sched/sch_taprio.c:10:
net//sched/sch_taprio.c: In function 'taprio_set_picos_per_byte':
>> include/linux/kern_levels.h:5:18: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'long int' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^~~~~~
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
include/linux/printk.h:309:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
net//sched/sch_taprio.c:600:2: note: in expansion of macro 'pr_info'
pr_info("taprio: set %s's picos_per_byte to: %lld, linkspeed: %d\n",
^~~~~~~
net//sched/sch_taprio.c:600:50: note: format string is defined here
pr_info("taprio: set %s's picos_per_byte to: %lld, linkspeed: %d\n",
~~~^
%ld
vim +5 include/linux/kern_levels.h
314ba352 Joe Perches 2012-07-30 4
04d2c8c8 Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */
04d2c8c8 Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001'
04d2c8c8 Joe Perches 2012-07-30 7
:::::: The code at line 5 was first introduced by commit
:::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_<LEVEL> to a 2 byte pattern
:::::: TO: Joe Perches <joe@perches•com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation•org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 56851 bytes --]
next prev parent reply other threads:[~2019-03-16 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 21:16 [PATCH net V3 0/2] net/sched: taprio: cbs: Fix using invalid link speed Leandro Dorileo
2019-03-15 21:16 ` [PATCH net V3 1/2] net/sched: taprio: fix picos_per_byte miscalculation Leandro Dorileo
2019-03-15 21:36 ` Florian Fainelli
2019-03-18 21:13 ` Leandro Dorileo
2019-03-16 9:00 ` kbuild test robot [this message]
2019-03-15 21:16 ` [PATCH net V3 2/2] net/sched: cbs: fix port_rate miscalculation Leandro Dorileo
2019-03-19 0:07 ` [PATCH net V3 0/2] net/sched: taprio: cbs: Fix using invalid link speed Patel, Vedang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201903161623.W06XxgoT%lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kbuild-all@01$(echo .)org \
--cc=leandro.maciel.dorileo@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vinicius.gomes@intel$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox