From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail•com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail•com>
Cc: Song Liu <songliubraving@fb•com>,
"bpf@vger•kernel.org" <bpf@vger•kernel.org>,
Networking <netdev@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Kernel Team <Kernel-team@fb•com>,
Peter Zijlstra <peterz@infradead•org>,
Arnaldo Carvalho de Melo <acme@redhat•com>,
Jiri Olsa <jolsa@kernel•org>, Namhyung Kim <namhyung@kernel•org>,
Stanislav Fomichev <sdf@fomichev•me>
Subject: Re: [WORKS!] Re: [PATCH v9 perf,bpf 12/15] perf, bpf: enable annotation of bpf program
Date: Tue, 19 Mar 2019 14:07:56 -0300 [thread overview]
Message-ID: <20190319170756.GJ3029@kernel.org> (raw)
In-Reply-To: <20190319165531.GI3029@kernel.org>
Em Tue, Mar 19, 2019 at 01:55:31PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Mar 19, 2019 at 04:51:44PM +0000, Song Liu escreveu:
> >
> >
> > > On Mar 19, 2019, at 7:52 AM, Arnaldo Carvalho de Melo <arnaldo.melo@gmail•com> wrote:
> > >
> > > Em Tue, Mar 19, 2019 at 11:14:35AM -0300, Arnaldo Carvalho de Melo escreveu:
> > >>
> > >> Now the test is really being performed, the test-all.bin feature
> > >> detection fast path is working, proceeding.
> > >
> > > Now it all works, really nice!
> > >
> > > I added a 'Committer testing' section with all the steps to test this
> > > and pushed to:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=6530d44e7dc1d41c73fe70b9e6ea1b9cabebb57f
> >
> > Thanks Arnaldo! This looks great!
> >
> > I will rebase https://lkml.org/lkml/2019/3/14/681 on top of this branch
> > and resend.
>
> I just found one new bug, that may appear now since I took a series of
> fixes found by gcc's ASan feature, i.e. on the exit path we're crashing
> on:
>
> [root@quaco ~]# perf top
> perf: Segmentation fault
> -------- backtrace --------
> perf[0x5a785a]
> /lib64/libc.so.6(+0x385bf)[0x7fd68443c5bf]
> perf(rb_first+0x2b)[0x4d6eeb]
> perf(dso__delete+0xb7)[0x4dffb7]
> perf[0x4f9e37]
> perf(perf_session__delete+0x64)[0x504df4]
> perf(cmd_top+0x1957)[0x454467]
> perf[0x4aad18]
> perf(main+0x61c)[0x42ec7c]
> /lib64/libc.so.6(__libc_start_main+0xf2)[0x7fd684428412]
> perf(_start+0x2d)[0x42eead]
> [root@quaco ~]#
> [root@quaco ~]# addr2line -fe ~/bin/perf 0x4dffb7
> dso_cache__free
> /home/acme/git/perf/tools/perf/util/dso.c:713
>
>
> And that is because of that union:
>
> + union {
> + /* dso data file */
> + struct {
> + struct rb_root cache;
> + int fd;
> + int status;
> + u32 status_seen;
> + size_t file_size;
> + struct list_head open_entry;
> + u64 debug_frame_offset;
> + u64 eh_frame_hdr_offset;
> + } data;
> + /* bpf prog information */
> + struct {
> + u32 id;
> + u32 sub_id;
> + struct perf_env *env;
> + } bpf_prog;
> + };
>
>
> On the dso exit path, it is trying to traverse the data.cache rbtree,
> when what is that is that bpf_prog.id, etc, I'll just remove the union
> for now, later we can do the data.cache access or bpf_prog based on some
> other test.
One more on 32-bit arches, a uintptr_t case for the jited_ksyms on the
BPF annotate patch, will fix.
- Arnaldo
next prev parent reply other threads:[~2019-03-19 17:08 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 5:30 [PATCH v9 perf,bpf 00/15] perf annotation of BPF programs Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 01/15] perf-record: replace option --bpf-event with --no-bpf-event Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 02/15] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-03-12 13:50 ` Arnaldo Carvalho de Melo
2019-03-12 5:30 ` [PATCH v9 perf,bpf 03/15] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-03-13 21:00 ` Arnaldo Carvalho de Melo
2019-03-13 21:08 ` Arnaldo Carvalho de Melo
2019-03-14 5:08 ` Song Liu
2019-03-14 16:45 ` Song Liu
2019-03-14 18:30 ` Arnaldo Carvalho de Melo
2019-03-12 5:30 ` [PATCH v9 perf,bpf 05/15] perf: change prototype of perf_event__synthesize_bpf_events() Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-03-12 13:10 ` Jiri Olsa
2019-03-12 14:34 ` Arnaldo Carvalho de Melo
2019-03-12 5:30 ` [PATCH v9 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data Song Liu
2019-03-12 13:10 ` Jiri Olsa
2019-03-12 14:47 ` Arnaldo Carvalho de Melo
2019-03-13 19:05 ` Arnaldo Carvalho de Melo
2019-03-12 5:30 ` [PATCH v9 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env Song Liu
2019-03-12 15:00 ` Arnaldo Carvalho de Melo
2019-03-12 5:30 ` [PATCH v9 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data Song Liu
2019-03-12 15:14 ` Arnaldo Carvalho de Melo
2019-03-12 15:16 ` Arnaldo Carvalho de Melo
2019-03-12 16:26 ` Song Liu
2019-03-12 17:05 ` Arnaldo Carvalho de Melo
2019-03-12 17:29 ` Song Liu
2019-03-15 19:06 ` Arnaldo Carvalho de Melo
2019-03-15 19:26 ` Arnaldo Carvalho de Melo
2019-03-15 19:31 ` Song Liu
2019-03-15 19:42 ` Arnaldo Carvalho de Melo
2019-03-12 5:30 ` [PATCH v9 perf,bpf 10/15] perf-top: add option --no-bpf-event Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 12/15] perf, bpf: enable annotation of bpf program Song Liu
2019-03-18 16:38 ` Arnaldo Carvalho de Melo
2019-03-18 16:43 ` Arnaldo Carvalho de Melo
2019-03-19 6:10 ` Song Liu
2019-03-19 13:37 ` Arnaldo Carvalho de Melo
2019-03-19 6:05 ` Song Liu
2019-03-19 13:37 ` Arnaldo Carvalho de Melo
2019-03-19 13:58 ` Arnaldo Carvalho de Melo
2019-03-19 14:14 ` Arnaldo Carvalho de Melo
2019-03-19 14:52 ` [WORKS!] " Arnaldo Carvalho de Melo
2019-03-19 16:51 ` Song Liu
2019-03-19 16:55 ` Arnaldo Carvalho de Melo
2019-03-19 17:07 ` Arnaldo Carvalho de Melo [this message]
2019-03-12 5:30 ` [PATCH v9 perf,bpf 13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 14/15] perf: introduce side band thread Song Liu
2019-03-12 5:30 ` [PATCH v9 perf,bpf 15/15] perf, bpf: save bpf_prog_info and btf of short living bpf programs Song Liu
2019-03-19 15:25 ` Arnaldo Carvalho de Melo
2019-03-12 13:12 ` [PATCH v9 perf,bpf 00/15] perf annotation of BPF programs Jiri Olsa
2019-03-21 9:10 ` Jiri Olsa
2019-03-21 14:12 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319170756.GJ3029@kernel.org \
--to=arnaldo.melo@gmail$(echo .)com \
--cc=Kernel-team@fb$(echo .)com \
--cc=acme@redhat$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=jolsa@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=namhyung@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=sdf@fomichev$(echo .)me \
--cc=songliubraving@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox