From: Jiri Pirko <jiri@resnulli•us>
To: Andrew Lunn <andrew@lunn•ch>
Cc: netdev@vger•kernel.org, davem@davemloft•net, mlxsw@mellanox•com,
idosch@mellanox•com, jakub.kicinski@netronome•com,
f.fainelli@gmail•com, vivien.didelot@gmail•com
Subject: Re: [patch net-next 09/11] dsa: move devlink_port_attrs_set() call before register
Date: Thu, 21 Mar 2019 14:44:14 +0100 [thread overview]
Message-ID: <20190321134414.GG2087@nanopsycho> (raw)
In-Reply-To: <20190321134101.GA17655@lunn.ch>
Thu, Mar 21, 2019 at 02:41:01PM CET, andrew@lunn•ch wrote:
>On Thu, Mar 21, 2019 at 02:20:17PM +0100, Jiri Pirko wrote:
>> + switch (dp->type) {
>> + case DSA_PORT_TYPE_CPU:
>> + flavour = DEVLINK_PORT_FLAVOUR_CPU;
>> + break;
>> + case DSA_PORT_TYPE_DSA:
>> + flavour = DEVLINK_PORT_FLAVOUR_DSA;
>> + break;
>> + case DSA_PORT_TYPE_USER: /* fall-through */
>> + default:
>> + flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
>> + break;
>> + }
>> +
>> + /* dp->index is used now as port_number. However
>> + * CPU ports should have separate numbering
>> + * independent from front panel port numbers.
>> + */
>
>Hi Jiri
>
>Given the way you have rearranged this code, i think the text above
>should now be:
>
>However CPU ports and DSA ports should have separate numbering.
You are right. Will fix in v2.
>
> Andrew
next prev parent reply other threads:[~2019-03-21 13:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 13:20 [patch net-next 00/11] devlink: small spring cleanup Jiri Pirko
2019-03-21 13:20 ` [patch net-next 01/11] net: devlink: add couple of missing mutex_destroy() calls Jiri Pirko
2019-03-21 13:20 ` [patch net-next 02/11] bnxt: add missing net/devlink.h include Jiri Pirko
2019-03-22 9:16 ` Vasundhara Volam
2019-03-22 13:38 ` Jiri Pirko
2019-03-21 13:20 ` [patch net-next 03/11] dsa: " Jiri Pirko
2019-03-21 14:12 ` Andrew Lunn
2019-03-21 13:20 ` [patch net-next 04/11] bnxt: set devlink port attrs properly Jiri Pirko
2019-03-21 13:20 ` [patch net-next 05/11] bnxt: call devlink_port_type_eth_set() before port register Jiri Pirko
2019-03-21 13:20 ` [patch net-next 06/11] net: devlink: don't take devlink_mutex for devlink_compat_* Jiri Pirko
2019-03-21 19:08 ` Jakub Kicinski
2019-03-22 13:44 ` Jiri Pirko
2019-03-21 13:20 ` [patch net-next 07/11] net: devlink: don't pass return value of __devlink_port_type_set() Jiri Pirko
2019-03-21 13:20 ` [patch net-next 08/11] mlxsw: Move devlink_port_attrs_set() call before register Jiri Pirko
2019-03-21 13:20 ` [patch net-next 09/11] dsa: move " Jiri Pirko
2019-03-21 13:41 ` Andrew Lunn
2019-03-21 13:44 ` Jiri Pirko [this message]
2019-03-21 13:20 ` [patch net-next 10/11] net: devlink: disallow port_attrs_set() to be called " Jiri Pirko
2019-03-21 13:20 ` [patch net-next 11/11] net: devlink: add port type spinlock Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321134414.GG2087@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox