From: Marek Behun <marek.behun@nic•cz>
To: Christian Lamparter <chunkeey@gmail•com>
Cc: "Florian Fainelli" <f.fainelli@gmail•com>,
netdev@vger•kernel.org, "Andrew Lunn" <andrew@lunn•ch>,
"Michal Vokáč" <vokac.m@gmail•com>,
"John Crispin" <john@phrozen•org>,
"Wei Yongjun" <weiyongjun1@huawei•com>
Subject: Re: [PATCH net-next 1/1] net: dsa: qca8k: Fix internal PHY MDIO address
Date: Fri, 22 Mar 2019 00:01:20 +0100 [thread overview]
Message-ID: <20190322000120.7a87fde5@nic.cz> (raw)
In-Reply-To: <2275278.j5OWp99DLc@debian64>
> Hm, it's not really a "external mode". But let's try one more time.
> The idea is that if an external mdio-bus (from the SoC) has already
> registered the PHY 0x0 - 0x4 from the QCA8337, the qca8k should not
> expose the same PHYs as it's own mdio-bus because then the PHYs end
> up being registered twice.
Hi,
yes, I understand this bit. What I was talking about was that the MDIO
addresses of internal PHYs are 0 to 4, it does not matter if you access
them via switch or directly. But the current code for direct access is
using addresses 1 to 5, which does not work at all. It should also
substract 1 from the port number.
Marek
next prev parent reply other threads:[~2019-03-21 23:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 18:23 [PATCH net-next 1/1] net: dsa: qca8k: Fix internal PHY MDIO address Marek Behún
2019-03-21 18:26 ` Florian Fainelli
2019-03-21 19:55 ` Marek Behun
2019-03-21 22:24 ` Christian Lamparter
2019-03-21 23:01 ` Marek Behun [this message]
2019-03-22 0:05 ` Christian Lamparter
2019-03-25 17:51 ` Christian Lamparter
2019-03-25 19:34 ` Marek Behun
2019-03-21 19:56 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322000120.7a87fde5@nic.cz \
--to=marek.behun@nic$(echo .)cz \
--cc=andrew@lunn$(echo .)ch \
--cc=chunkeey@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vokac.m@gmail$(echo .)com \
--cc=weiyongjun1@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox