Subject: Re: [patch net-next 02/11] bnxt: add missing net/devlink.h include

From: Jiri Pirko <[email-masked]>
Date: Fri, 22 Mar 2019 14:38:50 +0100

Fri, Mar 22, 2019 at 10:16:34AM CET, [email-masked] wrote:
>On Thu, Mar 21, 2019 at 6:50 PM Jiri Pirko <[email-masked]> wrote:
>>
>> From: Jiri Pirko <[email-masked]>
>>
>> devlink functions are in use, so include the related header file.
>>
>> Signed-off-by: Jiri Pirko <[email-masked]>
>> ---
>>  drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>> index e1feb97bcd81..ecb328ee8f5c 100644
>> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
>> @@ -9,6 +9,7 @@
>>
>>  #include <linux/pci.h>
>>  #include <linux/netdevice.h>
>> +#include <net/devlink.h>
>Jiri,
>This net/devlink.h file is already included in bnxt.h file which is
>included in bnxt_devlink.c.
>Do you face any issues with existing code while compiling or testing?

It is better to include directly, not to rely on some header to include
it.

>Thanks,
>Vasundhara
>>  #include "bnxt_hsi.h"
>>  #include "bnxt.h"
>>  #include "bnxt_vfr.h"
>> --
>> 2.17.2