From: Jesper Dangaard Brouer <brouer@redhat•com>
To: Heiner Kallweit <hkallweit1@gmail•com>
Cc: Edward Cree <ecree@solarflare•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
brouer@redhat•com
Subject: Re: netif_receive_skb_list and interrupts enabled/disabled
Date: Wed, 27 Mar 2019 09:20:11 +0100 [thread overview]
Message-ID: <20190327092011.0fded74d@carbon> (raw)
In-Reply-To: <5c170def-4c09-8da2-e0cd-6fc29881031f@gmail.com>
On Tue, 26 Mar 2019 21:04:09 +0100
Heiner Kallweit <hkallweit1@gmail•com> wrote:
> A question inspired by 0a25d92c6f4f ("dpaa2-eth: use netif_receive_skb_list"):
> kerneldoc of netif_receive_skb_list states that interrupts should be
> enabled.
Do notice that the exact same comment (and rule) applies to
netif_receive_skb() which also have below comment:
/* [...]
* This function may only be called from softirq context and interrupts
* should be enabled.
*/
> When used from NAPI context irqs typically are disabled.
> And if the NAPI budget is fully consumed then interrupts don't get enabled
> in the same NAPI poll loop. How is this supposed to play together?
You have misunderstood that is means that interrupts should be
enabled. It is talking about local_irq_disable/enable and
local_irq_save/restore. This is different from disabling the IRQs on a
given NIC RX-queue.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-03-27 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 20:04 netif_receive_skb_list and interrupts enabled/disabled Heiner Kallweit
2019-03-27 8:20 ` Jesper Dangaard Brouer [this message]
2019-03-27 18:55 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327092011.0fded74d@carbon \
--to=brouer@redhat$(echo .)com \
--cc=ecree@solarflare$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox