Subject: Re: [PATCH net-next 13/13] net: Use common nexthop init and release helpers

From: Ido Schimmel <[email-masked]>
Date: Wed, 27 Mar 2019 09:46:52 +0000

On Tue, Mar 26, 2019 at 08:29:42PM -0700, David Ahern wrote:
> From: David Ahern <[email-masked]>
> 
> With fib_nh_common in place, move common initialization and release
> code into helpers used by both ipv4 and ipv6. For the moment, the init
> is just the lwt encap and the release is both the net dev reference and

s/net dev/netdev/

> the the lwt state reference. More will be added later.
> 
> Signed-off-by: David Ahern <[email-masked]>
> ---
>  include/net/ip_fib.h     |  4 ++++
>  net/ipv4/fib_semantics.c | 60 +++++++++++++++++++++++++++++++-----------------

I don't really mind, but shouldn't the common parts be placed under
net/core/ ? Like how the FIB rules have a common code in
net/core/fib_rules.c ?

>  net/ipv6/route.c         | 21 ++++-------------
>  3 files changed, 48 insertions(+), 37 deletions(-)