Subject: Re: [PATCH 4/4] ethtool: add PHY Fast Link Down tunable to man page

From: Andrew Lunn <[email-masked]>
Date: Thu, 28 Mar 2019 21:01:03 +0100

> +	Sets the period after which the link is reported as down. Note that the PHY may choose
> +	the closest supported value. Only on reading back you get the actual value.

Hi Heiner

'Only on reading back the tunable do you get the actual value.'

would be better.

>  .TE
>  .PD
>  .RE
> @@ -1090,6 +1106,14 @@ Link speed downshift after N failed 1000BASE-T auto-negotiation attempts.
>  Downshift is useful where cable does not have the 4 pairs instance.
>  
>  Gets the PHY downshift count/status.
> +.TP
> +.B fast\-link\-down
> +Depending on the mode it may take 0.5s - 1s until a broken link is reported as down.
> +In certain use cases a link-down event needs to be reported as soon as possible.
> +Some PHYs support a Fast Link Down feature, and partially even allow to configure
> +the period until until a broken link is reported as being down.

Some PHYs support a Fast Link Down Feature and may allow configuration
of the delay before a broken link is reported as being down.

   Andrew