public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips•org>
To: netdev@vger•kernel.org
Subject: iproute2: Issue with link type link/generic for NETROM links
Date: Thu, 4 Apr 2019 12:21:54 +0200	[thread overview]
Message-ID: <20190404102154.GA427@linux-mips.org> (raw)

For a NETROM "ip link show dev nr0" will show

4: nr0: <NOARP,UP,LOWER_UP> mtu 236 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/generic 88:98:6a:a4:84:40:0a brd 00:00:00:00:00:00:00

But rather link/netrom is expected to be displayed.

I have below patch to change ip such that link/netrom will be displayed
but I'm wondering if it's going to cause non-obvious breakage or would
be acceptable?

Thanks,

  Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips•org>

 lib/ll_types.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ll_types.c b/lib/ll_types.c
index bd8893ed..32d04b5a 100644
--- a/lib/ll_types.c
+++ b/lib/ll_types.c
@@ -32,7 +32,7 @@ static const struct {
 	int type;
 	const char *name;
 } arphrd_names[] = {
-{ 0, "generic" },
+__PF(NETROM,netrom)
 __PF(ETHER,ether)
 __PF(EETHER,eether)
 __PF(AX25,ax25)

             reply	other threads:[~2019-04-04 10:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 10:21 Ralf Baechle [this message]
2019-04-11 22:25 ` iproute2: Issue with link type link/generic for NETROM links Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404102154.GA427@linux-mips.org \
    --to=ralf@linux-mips$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox