From: Andrew Lunn <andrew@lunn•ch>
To: Michael Zhivich <mzhivich@akamai•com>
Cc: davem@davemloft•net, siva.kallam@broadcom•com,
prashant@broadcom•com, mchan@broadcom•com, shshaikh@marvell•com,
manishc@marvell•com, netdev@vger•kernel.org
Subject: Re: [PATCH v2 3/3] qlogic: qlcnic: fix use of SPEED_UNKNOWN ethtool constant
Date: Mon, 8 Apr 2019 19:53:08 +0200 [thread overview]
Message-ID: <20190408175308.GF15267@lunn.ch> (raw)
In-Reply-To: <1554734927-15522-4-git-send-email-mzhivich@akamai.com>
On Mon, Apr 08, 2019 at 10:48:47AM -0400, Michael Zhivich wrote:
> qlcnic driver uses u16 to store SPEED_UKNOWN ethtool constant,
> which is defined as -1, resulting in value truncation and
> thus incorrect test results against SPEED_UNKNOWN.
>
> For example, the following test will print "False":
>
> u16 speed = SPEED_UNKNOWN;
>
> if (speed == SPEED_UNKNOWN)
> printf("True");
> else
> printf("False");
>
> Change storage of speed to use u32 to avoid this issue.
>
> Signed-off-by: Michael Zhivich <mzhivich@akamai•com>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2019-04-08 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:48 [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant Michael Zhivich
2019-04-08 14:48 ` [PATCH v2 1/3] ethtool: avoid signed-unsigned comparison in ethtool_validate_speed() Michael Zhivich
2019-04-08 14:48 ` [PATCH v2 2/3] broadcom: tg3: fix use of SPEED_UNKNOWN ethtool constant Michael Zhivich
2019-04-08 17:52 ` Andrew Lunn
2019-04-08 14:48 ` [PATCH v2 3/3] qlogic: qlcnic: " Michael Zhivich
2019-04-08 17:53 ` Andrew Lunn [this message]
2019-04-08 17:54 ` [PATCH v2 0/3] ethtool: fix use of SPEED_UNKNOWN constant Andrew Lunn
2019-04-08 18:40 ` Zhivich, Michael
2019-04-08 23:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408175308.GF15267@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=manishc@marvell$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=mzhivich@akamai$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=prashant@broadcom$(echo .)com \
--cc=shshaikh@marvell$(echo .)com \
--cc=siva.kallam@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox