From: Andrew Lunn <andrew@lunn•ch>
To: Heiner Kallweit <hkallweit1@gmail•com>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
David Miller <davem@davemloft•net>, Ray Jui <rjui@broadcom•com>,
Scott Branden <sbranden@broadcom•com>,
Richard Cochran <richardcochran@gmail•com>,
Kevin Hilman <khilman@baylibre•com>,
Heiko Stuebner <heiko@sntech•de>,
bcm-kernel-feedback-list@broadcom•com, netdev@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-amlogic@lists•infradead.org,
linux-rockchip@lists•infradead.org
Subject: Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection
Date: Sat, 13 Apr 2019 00:47:37 +0200 [thread overview]
Message-ID: <20190412224737.GA1004@lunn.ch> (raw)
In-Reply-To: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com>
On Fri, Apr 12, 2019 at 08:47:03PM +0200, Heiner Kallweit wrote:
> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.
>
> I don't have access to most of these PHY's, therefore I'd appreciate
> regression testing.
Hi Heiner
I tested v1 on the following PHYs:
88E1510, 88E1540, 88E6390, KSZ8041, 88E1545
No obvious regressions.
Tested-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2019-04-12 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 18:47 [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection Heiner Kallweit
2019-04-12 22:47 ` Andrew Lunn [this message]
2019-04-16 0:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412224737.GA1004@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=hkallweit1@gmail$(echo .)com \
--cc=khilman@baylibre$(echo .)com \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=rjui@broadcom$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox