Subject: Re: [PATCH v2 net-next 01/16] net: aquantia: add infrastructure to readout chip temperature

From: Andrew Lunn <[email-masked]>
Date: Tue, 23 Apr 2019 21:12:50 +0200

On Tue, Apr 23, 2019 at 01:17:29PM +0000, Igor Russkikh wrote:
> From: Yana Esina <[email-masked]>
> 
> Ability to read the chip temperature from memory
> via hwmon interface
> 
> Signed-off-by: Yana Esina <[email-masked]>
> Signed-off-by: Nikita Danilov <[email-masked]>
> Signed-off-by: Igor Russkikh <[email-masked]>
> ---
>  .../net/ethernet/aquantia/atlantic/aq_hw.h    |  2 ++
>  .../aquantia/atlantic/hw_atl/hw_atl_utils.c   |  1 +
>  .../atlantic/hw_atl/hw_atl_utils_fw2x.c       | 36 +++++++++++++++++++
>  3 files changed, 39 insertions(+)
> 
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_hw.h b/drivers/net/ethernet/aquantia/atlantic/aq_hw.h
> index 81aab73dc22f..538593261ae3 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_hw.h
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_hw.h
> @@ -259,6 +259,8 @@ struct aq_fw_ops {
>  
>  	int (*update_stats)(struct aq_hw_s *self);
>  
> +	int (*get_temp)(struct aq_hw_s *self, int *temp);
> +

We talked about renaming this get_phy_temp so you could later add
get_mac_temp?

	Andrew