Subject: Re: [PATCH v2 net-next 02/16] net: aquantia: implement hwmon api for chip temperature

From: Andrew Lunn <[email-masked]>
Date: Tue, 23 Apr 2019 21:17:58 +0200

> +static u32 aq_hwmon_temp_config[] = {
> +	HWMON_T_INPUT | HWMON_T_LABEL,
> +	0,

It would be nice to also have

        HWMON_T_MAX | HWMON_T_MIN |
        HWMON_T_CRIT | HWMON_T_LCRIT |

which the PHY probably has.

At gives some degree of context. A temperature on its own of say 65C
is hard to interpret. Is it too hot?  But if we have a critical of 85C
and a max of 95C we know we are O.K.

	 Andrew