Subject: Re: [PATCH][next] mwifiex: use struct_size() in kzalloc()

From: Kalle Valo <[email-masked]>
Date: Thu, 25 Apr 2019 16:45:33 +0000 (UTC)

"Gustavo A. R. Silva" <[email-masked]> wrote:

> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
> 
> struct foo {
>     int stuff;
>     struct boo entry[];
> };
> 
> size = sizeof(struct foo) + count * sizeof(struct boo);
> instance = kzalloc(size, GFP_KERNEL)
> 
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
> 
> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL)
> 
> Notice that, in this case, variable regd_size is not necessary,
> hence it is removed.
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <[email-masked]>

Patch applied to wireless-drivers-next.git, thanks.

ae187ba91541 mwifiex: use struct_size() in kzalloc()

-- 
https://patchwork.kernel.org/patch/10884249/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches