Subject: Re: [PATCH v8 03/15] wlcore: simplify/fix/optimize reg_ch_conf_pending operations

From: Kalle Valo <[email-masked]>
Date: Thu, 25 Apr 2019 17:12:30 +0000 (UTC)

Fenghua Yu <[email-masked]> wrote:

> From: Paolo Bonzini <[email-masked]>
> 
> Bitmaps are defined on unsigned longs, so the usage of u32[2] in the
> wlcore driver is incorrect.  As noted by Peter Zijlstra, casting arrays
> to a bitmap is incorrect for big-endian architectures.
> 
> When looking at it I observed that:
> 
> - operations on reg_ch_conf_pending is always under the wl_lock mutex,
> so set_bit is overkill
> 
> - the only case where reg_ch_conf_pending is accessed a u32 at a time is
> unnecessary too.
> 
> This patch cleans up everything in this area, and changes tmp_ch_bitmap
> to have the proper alignment.
> 
> Signed-off-by: Paolo Bonzini <[email-masked]>
> Signed-off-by: Fenghua Yu <[email-masked]>

Patch applied to wireless-drivers-next.git, thanks.

147b502bda33 wlcore: simplify/fix/optimize reg_ch_conf_pending operations

-- 
https://patchwork.kernel.org/patch/10915635/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches