Subject: Re: [PATCH v3 net-next 06/15] net: aquantia: link status irq handling

From: Andrew Lunn <[email-masked]>
Date: Fri, 26 Apr 2019 23:16:48 +0200

> +		if (self->aq_nic_cfg.link_irq_vec) {
> +			int irqvec = pci_irq_vector(self->pdev,
> +						   self->aq_nic_cfg.link_irq_vec);
> +			err = request_threaded_irq(irqvec, NULL,
> +						   aq_linkstate_threaded_isr,
> +						   IRQF_SHARED,
> +						   self->ndev->name, self);

At some point you should consider using the devm_* API. It will make
your cleanup code simpler.

Reviewed-by: Andrew Lunn <[email-masked]>

    Andrew