Subject: Re: [PATCH v3 net-next 10/15] net: aquantia: introduce fwreq mutex

From: Andrew Lunn <[email-masked]>
Date: Fri, 26 Apr 2019 23:20:08 +0200

On Fri, Apr 26, 2019 at 09:48:02AM +0000, Igor Russkikh wrote:
> From: Nikita Danilov <[email-masked]>
> 
> Some of FW operations could be invoked simultaneously,
> from f.e. ethtool context and from service service activity work.
> Here we introduce a fw mutex to secure and serialize access
> to FW logic.
> 
> Signed-off-by: Nikita Danilov <[email-masked]>
> Signed-off-by: Igor Russkikh <[email-masked]>

I still think it would be a good idea to put in the low level code a
check that the mutex is actually held when talking to the firmware.

Reviewed-by: Andrew Lunn <[email-masked]>

    Andrew