Subject: Re: [PATCH] wireless: carl9170: fix clang build warning

From: Kalle Valo <[email-masked]>
Date: Mon, 29 Apr 2019 15:01:24 +0000 (UTC)

Arnd Bergmann <[email-masked]> wrote:

> clang fails to eliminate some dead code with always-taken branches
> when CONFIG_PROFILE_ANNOTATED_BRANCHES is set, leading to a false-positive
> warning:
> 
> drivers/net/wireless/ath/carl9170/mac.c:522:3: error: variable 'power' is used uninitialized whenever 'if' condition is
>       false [-Werror,-Wsometimes-uninitialized]
>                 BUG_ON(1);
>                 ^~~~~~~~~
> 
> Change both instances of BUG_ON(1) in carl9170 to the simpler BUG()
> to avoid the warning.
> 
> Signed-off-by: Arnd Bergmann <[email-masked]>
> Acked-by: Christian Lamparter <[email-masked]>
> Signed-off-by: Kalle Valo <[email-masked]>

Patch applied to ath-next branch of ath.git, thanks.

62acdcfa8b7a wireless: carl9170: fix clang build warning

-- 
https://patchwork.kernel.org/patch/10869053/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches