From: Joel Fernandes <joel@joelfernandes•org>
To: Masami Hiramatsu <mhiramat@kernel•org>
Cc: linux-kernel@vger•kernel.org,
Michal Gregorczyk <michalgr@live•com>,
Adrian Ratiu <adrian.ratiu@collabora•com>,
Mohammad Husain <russoue@gmail•com>,
Qais Yousef <qais.yousef@arm•com>,
Srinivas Ramana <sramana@codeaurora•org>,
duyuchao <yuchao.du@unisoc•com>,
Manjo Raja Rao <linux@manojrajarao•com>,
Karim Yaghmour <karim.yaghmour@opersys•com>,
Tamir Carmeli <carmeli.tamir@gmail•com>,
Yonghong Song <yhs@fb•com>, Alexei Starovoitov <ast@kernel•org>,
Brendan Gregg <brendan.d.gregg@gmail•com>,
Peter Ziljstra <peterz@infradead•org>,
Steven Rostedt <rostedt@goodmis•org>,
Kees Cook <keescook@chromium•org>,
kernel-team@android•com, Daniel Borkmann <daniel@iogearbox•net>,
Ingo Molnar <mingo@redhat•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH RFC] bpf: Add support for reading user pointers
Date: Mon, 6 May 2019 12:14:29 -0400 [thread overview]
Message-ID: <20190506161429.GB234965@google.com> (raw)
In-Reply-To: <20190506234751.65c92139dccbfa025bdfe300@kernel.org>
On Mon, May 06, 2019 at 11:47:51PM +0900, Masami Hiramatsu wrote:
> Hi Joel,
>
> On Thu, 2 May 2019 16:49:58 -0400
> "Joel Fernandes (Google)" <joel@joelfernandes•org> wrote:
>
> > The eBPF based opensnoop tool fails to read the file path string passed
> > to the do_sys_open function. This is because it is a pointer to
> > userspace address and causes an -EFAULT when read with
> > probe_kernel_read. This is not an issue when running the tool on x86 but
> > is an issue on arm64. This patch adds a new bpf function call based
> > which calls the recently proposed probe_user_read function [1].
> > Using this function call from opensnoop fixes the issue on arm64.
> >
> > [1] https://lore.kernel.org/patchwork/patch/1051588/
>
> Anyway, this series is still out-of-tree. We have to push this or similar
> update into kernel at first. I can resend v7 on the latest -tip tree including
> this patch if you update the description.
Sounds good. I also have to split it up and add a deprecation for the old
API. I will get this done today and then you can include them in your series,
thanks! Once I send them, could you CC bpf maintainers on the patches too in
the future? thanks.
- Joel
prev parent reply other threads:[~2019-05-06 16:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 20:49 [PATCH RFC] bpf: Add support for reading user pointers Joel Fernandes (Google)
2019-05-03 12:12 ` Qais Yousef
2019-05-03 13:49 ` Joel Fernandes
2019-05-03 13:54 ` Peter Zijlstra
2019-05-03 15:09 ` Joel Fernandes
2019-05-05 11:04 ` Qais Yousef
2019-05-05 13:29 ` Joel Fernandes
2019-05-05 14:46 ` Qais Yousef
2019-05-05 15:52 ` Joel Fernandes
2019-05-05 18:03 ` Joel Fernandes
2019-05-05 18:51 ` Andrii Nakryiko
2019-05-06 0:01 ` Qais Yousef
2019-05-06 18:35 ` Will Deacon
2019-05-06 20:58 ` Joel Fernandes
2019-05-06 21:57 ` Qais Yousef
2019-05-07 9:52 ` Will Deacon
2019-05-08 2:00 ` Joel Fernandes
2019-05-05 7:19 ` Alexei Starovoitov
2019-05-05 13:33 ` Joel Fernandes
2019-05-06 14:47 ` Masami Hiramatsu
2019-05-06 16:14 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506161429.GB234965@google.com \
--to=joel@joelfernandes$(echo .)org \
--cc=adrian.ratiu@collabora$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=brendan.d.gregg@gmail$(echo .)com \
--cc=carmeli.tamir@gmail$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=karim.yaghmour@opersys$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-team@android$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@manojrajarao$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=michalgr@live$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=qais.yousef@arm$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=russoue@gmail$(echo .)com \
--cc=sramana@codeaurora$(echo .)org \
--cc=yhs@fb$(echo .)com \
--cc=yuchao.du@unisoc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox