From: Andrew Lunn <andrew@lunn•ch>
To: Linus Walleij <linus.walleij@linaro•org>
Cc: netdev@vger•kernel.org, "David S . Miller" <davem@davemloft•net>,
Krzysztof Halasa <khalasa@piap•pl>
Subject: Re: [PATCH 7/8] net: ethernet: ixp4xx: Add DT bindings
Date: Fri, 24 May 2019 22:06:51 +0200 [thread overview]
Message-ID: <20190524200651.GQ21208@lunn.ch> (raw)
In-Reply-To: <20190524162023.9115-8-linus.walleij@linaro.org>
> +description: |
> + The Intel IXP4xx ethernet makes use of the IXP4xx NPE (Network
> + Processing Engine) and the IXP4xx Queue Mangager to process
> + the ethernet frames. It can optionally contain an MDIO bus to
> + talk to PHYs.
Hi Linus
You mention MDIO and PHYs, but the code is not there yet. When you do
add the needed code, it is a good idea to place the PHY nodes inside a
container node:
ethernet@c8009000 {
compatible = "intel,ixp4xx-ethernet";
reg = <0xc8009000 0x1000>;
status = "disabled";
queue-rx = <&qmgr 3>;
queue-txready = <&qmgr 20>;
mdio {
phy0: phy@0 {
reg = <0>;
};
};
};
Andrew
next prev parent reply other threads:[~2019-05-24 20:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 16:20 [PATCH 0/8] Xscale IXP4xx ethernet refurbishing Linus Walleij
2019-05-24 16:20 ` [PATCH 1/8] net: ethernet: ixp4xx: Standard module init Linus Walleij
2019-05-24 19:46 ` Andrew Lunn
2019-05-29 7:10 ` Linus Walleij
2019-05-24 16:20 ` [PATCH 2/8] net: ethernet: ixp4xx: Use distinct local variable Linus Walleij
2019-05-24 16:20 ` [PATCH 3/8] net: ehernet: ixp4xx: Use devm_alloc_etherdev() Linus Walleij
2019-05-24 19:52 ` Andrew Lunn
2019-05-24 16:20 ` [PATCH 4/8] ARM/net: ixp4xx: Pass ethernet physical base as resource Linus Walleij
2019-05-24 20:00 ` Andrew Lunn
2019-05-25 9:14 ` Sergei Shtylyov
2019-05-28 13:21 ` Andrew Lunn
2019-05-24 16:20 ` [PATCH 5/8] net: ethernet: ixp4xx: Get port ID from base address Linus Walleij
2019-05-24 16:20 ` [PATCH 6/8] net: ethernet: ixp4xx: Use parent dev for DMA pool Linus Walleij
2019-05-24 16:20 ` [PATCH 7/8] net: ethernet: ixp4xx: Add DT bindings Linus Walleij
2019-05-24 20:06 ` Andrew Lunn [this message]
2019-05-29 7:13 ` Linus Walleij
2019-05-24 16:20 ` [PATCH 8/8] net: ethernet: ixp4xx: Support device tree probing Linus Walleij
2019-05-24 20:21 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2019-05-24 16:22 [PATCH 7/8] net: ethernet: ixp4xx: Add DT bindings Linus Walleij
2019-05-24 19:41 ` Rob Herring
2019-06-18 19:44 ` Linus Walleij
2019-06-18 20:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524200651.GQ21208@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=khalasa@piap$(echo .)pl \
--cc=linus.walleij@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox