From: Jiri Pirko <jiri@resnulli•us>
To: netdev@vger•kernel.org
Cc: davem@davemloft•net, mlxsw@mellanox•com,
jakub.kicinski@netronome•com, sthemmin@microsoft•com,
dsahern@gmail•com, saeedm@mellanox•com, leon@kernel•org,
f.fainelli@gmail•com
Subject: [patch net-next v2 6/7] mlxsw: Implement flash update status notifications
Date: Tue, 28 May 2019 13:48:45 +0200 [thread overview]
Message-ID: <20190528114846.1983-7-jiri@resnulli.us> (raw)
In-Reply-To: <20190528114846.1983-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@mellanox•com>
Implement mlxfw status_notify op by passing notification down to
devlink. Also notify about flash update begin and end.
Signed-off-by: Jiri Pirko <jiri@mellanox•com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 639bb5778ff3..5ac893d9dd12 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -294,6 +294,19 @@ static void mlxsw_sp_fsm_release(struct mlxfw_dev *mlxfw_dev, u32 fwhandle)
mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(mcc), mcc_pl);
}
+static void mlxsw_sp_status_notify(struct mlxfw_dev *mlxfw_dev,
+ const char *msg, const char *comp_name,
+ u32 done_bytes, u32 total_bytes)
+{
+ struct mlxsw_sp_mlxfw_dev *mlxsw_sp_mlxfw_dev =
+ container_of(mlxfw_dev, struct mlxsw_sp_mlxfw_dev, mlxfw_dev);
+ struct mlxsw_sp *mlxsw_sp = mlxsw_sp_mlxfw_dev->mlxsw_sp;
+
+ devlink_flash_update_status_notify(priv_to_devlink(mlxsw_sp->core),
+ msg, comp_name,
+ done_bytes, total_bytes);
+}
+
static const struct mlxfw_dev_ops mlxsw_sp_mlxfw_dev_ops = {
.component_query = mlxsw_sp_component_query,
.fsm_lock = mlxsw_sp_fsm_lock,
@@ -303,7 +316,8 @@ static const struct mlxfw_dev_ops mlxsw_sp_mlxfw_dev_ops = {
.fsm_activate = mlxsw_sp_fsm_activate,
.fsm_query_state = mlxsw_sp_fsm_query_state,
.fsm_cancel = mlxsw_sp_fsm_cancel,
- .fsm_release = mlxsw_sp_fsm_release
+ .fsm_release = mlxsw_sp_fsm_release,
+ .status_notify = mlxsw_sp_status_notify,
};
static int mlxsw_sp_firmware_flash(struct mlxsw_sp *mlxsw_sp,
@@ -321,8 +335,10 @@ static int mlxsw_sp_firmware_flash(struct mlxsw_sp *mlxsw_sp,
int err;
mlxsw_core_fw_flash_start(mlxsw_sp->core);
+ devlink_flash_update_begin_notify(priv_to_devlink(mlxsw_sp->core));
err = mlxfw_firmware_flash(&mlxsw_sp_mlxfw_dev.mlxfw_dev,
firmware, extack);
+ devlink_flash_update_end_notify(priv_to_devlink(mlxsw_sp->core));
mlxsw_core_fw_flash_end(mlxsw_sp->core);
return err;
--
2.17.2
next prev parent reply other threads:[~2019-05-28 11:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 11:48 [patch net-next v2 0/7] expose flash update status to user Jiri Pirko
2019-05-28 11:48 ` [patch net-next v2 1/7] mlxsw: Move firmware flash implementation to devlink Jiri Pirko
2019-05-29 6:03 ` Ido Schimmel
2019-05-28 11:48 ` [patch net-next v2 2/7] mlx5: " Jiri Pirko
2019-05-28 11:48 ` [patch net-next v2 3/7] mlxfw: Propagate error messages through extack Jiri Pirko
2019-05-29 6:03 ` Ido Schimmel
2019-05-28 11:48 ` [patch net-next v2 4/7] devlink: allow driver to update progress of flash update Jiri Pirko
2019-05-28 19:55 ` Jakub Kicinski
2019-05-29 6:04 ` Ido Schimmel
2019-05-28 11:48 ` [patch net-next v2 5/7] mlxfw: Introduce status_notify op and call it to notify about the status Jiri Pirko
2019-05-29 6:10 ` Ido Schimmel
2019-05-28 11:48 ` Jiri Pirko [this message]
2019-05-29 6:12 ` [patch net-next v2 6/7] mlxsw: Implement flash update status notifications Ido Schimmel
2019-05-28 11:48 ` [patch net-next v2 7/7] netdevsim: implement fake flash updating with notifications Jiri Pirko
2019-05-28 20:01 ` Jakub Kicinski
2019-05-29 8:00 ` Jiri Pirko
2019-05-29 16:47 ` Jakub Kicinski
2019-05-29 19:30 ` Jiri Pirko
2019-05-28 11:50 ` [patch net-next v2 1/3] header update Jiri Pirko
2019-05-28 11:50 ` [patch net-next v2 2/3] devlink: implement flash update status monitoring Jiri Pirko
2019-05-28 11:50 ` [patch net-next v2 3/3] devlink: implement flash " Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528114846.1983-7-jiri@resnulli.us \
--to=jiri@resnulli$(echo .)us \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@mellanox$(echo .)com \
--cc=sthemmin@microsoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox