From: Takashi Sakamoto <o-takashi@sakamocchi•jp>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: Igor Konopko <igor.j.konopko@intel•com>,
David Howells <dhowells@redhat•com>,
"Mohit P . Tahiliani" <tahiliani@nitk•edu.in>,
Eran Ben Elisha <eranbe@mellanox•com>,
Matias Bjorling <mb@lightnvm•io>, Jiri Pirko <jiri@mellanox•com>,
"David S . Miller" <davem@davemloft•net>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Clemens Ladisch <clemens@ladisch•de>,
Jaroslav Kysela <perex@perex•cz>, Takashi Iwai <tiwai@suse•com>,
Joe Perches <joe@perches•com>, Arnd Bergmann <arnd@arndb•de>,
Dan Carpenter <dan.carpenter@oracle•com>,
linux-block@vger•kernel.org, netdev@vger•kernel.org,
linux-afs@lists•infradead.org, alsa-devel@alsa-project•org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants
Date: Wed, 29 May 2019 18:57:31 +0900 [thread overview]
Message-ID: <20190529095730.GA7089@workstation> (raw)
In-Reply-To: <20190528142424.19626-5-geert@linux-m68k.org>
Hi,
On Tue, May 28, 2019 at 04:24:23PM +0200, Geert Uytterhoeven wrote:
> With gcc 4.1:
>
> sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_switch_fetching_mode’:
> sound/firewire/fireface/ff-protocol-latter.c:97: warning: integer constant is too large for ‘long’ type
> sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_begin_session’:
> sound/firewire/fireface/ff-protocol-latter.c:170: warning: integer constant is too large for ‘long’ type
> sound/firewire/fireface/ff-protocol-latter.c:197: warning: integer constant is too large for ‘long’ type
> sound/firewire/fireface/ff-protocol-latter.c:205: warning: integer constant is too large for ‘long’ type
> sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_finish_session’:
> sound/firewire/fireface/ff-protocol-latter.c:214: warning: integer constant is too large for ‘long’ type
>
> Fix this by adding the missing "ULL" suffixes.
> Add the same suffix to the last constant, to maintain consistency.
>
> Fixes: fd1cc9de64c2ca6c ("ALSA: fireface: add support for Fireface UCX")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k•org>
> ---
> sound/firewire/fireface/ff-protocol-latter.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Thanks for your care.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi•jp>
> diff --git a/sound/firewire/fireface/ff-protocol-latter.c b/sound/firewire/fireface/ff-protocol-latter.c
> index c8236ff89b7fb9de..b30d02d359b1d21b 100644
> --- a/sound/firewire/fireface/ff-protocol-latter.c
> +++ b/sound/firewire/fireface/ff-protocol-latter.c
> @@ -9,11 +9,11 @@
>
> #include "ff.h"
>
> -#define LATTER_STF 0xffff00000004
> -#define LATTER_ISOC_CHANNELS 0xffff00000008
> -#define LATTER_ISOC_START 0xffff0000000c
> -#define LATTER_FETCH_MODE 0xffff00000010
> -#define LATTER_SYNC_STATUS 0x0000801c0000
> +#define LATTER_STF 0xffff00000004ULL
> +#define LATTER_ISOC_CHANNELS 0xffff00000008ULL
> +#define LATTER_ISOC_START 0xffff0000000cULL
> +#define LATTER_FETCH_MODE 0xffff00000010ULL
> +#define LATTER_SYNC_STATUS 0x0000801c0000ULL
>
> static int parse_clock_bits(u32 data, unsigned int *rate,
> enum snd_ff_clock_src *src)
> --
> 2.17.1
>
Regards
Takashi Sakamoto
next prev parent reply other threads:[~2019-05-29 10:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 14:24 [PATCH 0/5] Assorted fixes discovered with gcc 4.1 Geert Uytterhoeven
2019-05-28 14:24 ` [PATCH 1/5] lightnvm: Fix uninitialized pointer in nvm_remove_tgt() Geert Uytterhoeven
2019-05-29 8:08 ` Matias Bjørling
2019-05-29 8:12 ` Geert Uytterhoeven
2019-05-28 14:24 ` [PATCH 2/5] rxrpc: Fix uninitialized error code in rxrpc_send_data_packet() Geert Uytterhoeven
2019-05-28 16:30 ` David Howells
2019-05-29 11:49 ` Arnd Bergmann
2019-05-31 10:34 ` [PATCH] " David Howells
2019-06-03 21:30 ` David Miller
2019-06-04 7:17 ` Geert Uytterhoeven
2019-06-04 7:34 ` David Howells
2019-06-04 7:35 ` Geert Uytterhoeven
2019-05-28 14:24 ` [PATCH 3/5] net: sched: pie: Use ULL suffix for 64-bit constant Geert Uytterhoeven
2019-05-29 11:39 ` Arnd Bergmann
2019-05-28 14:24 ` [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants Geert Uytterhoeven
2019-05-29 9:57 ` Takashi Sakamoto [this message]
2019-05-29 10:07 ` Takashi Iwai
2019-05-28 14:24 ` [PATCH 5/5] [RFC] devlink: Fix uninitialized error code in devlink_fmsg_prepare_skb() Geert Uytterhoeven
2019-05-28 14:40 ` Eran Ben Elisha
2019-05-29 8:04 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529095730.GA7089@workstation \
--to=o-takashi@sakamocchi$(echo .)jp \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=clemens@ladisch$(echo .)de \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=eranbe@mellanox$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=igor.j.konopko@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mb@lightnvm$(echo .)io \
--cc=netdev@vger$(echo .)kernel.org \
--cc=perex@perex$(echo .)cz \
--cc=tahiliani@nitk$(echo .)edu.in \
--cc=tiwai@suse$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox