From: Andrew Lunn <andrew@lunn•ch>
To: Robert Hancock <hancock@sedsystems•ca>
Cc: netdev@vger•kernel.org, anirudh@xilinx•com, John.Linn@xilinx•com
Subject: Re: [PATCH net-next 01/13] net: axienet: Fixed 64-bit compile, enable build on X86 and ARM
Date: Fri, 31 May 2019 23:10:43 +0200 [thread overview]
Message-ID: <20190531211043.GD3154@lunn.ch> (raw)
In-Reply-To: <1559326545-28825-2-git-send-email-hancock@sedsystems.ca>
Hi Robert
I think you can split this into three patches, in order to make it
easier to review:
IO accessors
skb in the control block
MDIO changes.
> static inline u32 axienet_ior(struct axienet_local *lp, off_t offset)
> {
> - return in_be32(lp->regs + offset);
> +#ifdef CONFIG_MICROBLAZE
> + return __raw_readl(lp->regs + offset);
> +#else
> + return ioread32(lp->regs + offset);
> +#endif
> }
Please dig deeper into the available accessor functions. There should
be a set which works without this #defery.
Andrew
next prev parent reply other threads:[~2019-05-31 21:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 18:15 [PATCH net-next 00/13] Xilinx axienet driver updates Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 01/13] net: axienet: Fixed 64-bit compile, enable build on X86 and ARM Robert Hancock
2019-05-31 21:10 ` Andrew Lunn [this message]
2019-05-31 23:28 ` Robert Hancock
2019-06-01 3:04 ` Andrew Lunn
2019-06-02 6:37 ` kbuild test robot
2019-05-31 18:15 ` [PATCH net-next 02/13] net: axienet: clean up MDIO handling Robert Hancock
2019-05-31 21:13 ` Andrew Lunn
2019-05-31 18:15 ` [PATCH net-next 03/13] net: axienet: Cleanup DMA device reset and halt process Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 04/13] net: axienet: Make RX/TX ring sizes configurable Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 05/13] net: axienet: Add DMA registers to ethtool register dump Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 06/13] net: axienet: Support shared interrupts Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 07/13] net: axienet: Add optional support for Ethernet core interrupt Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 08/13] net: axienet: Fix race condition causing TX hang Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 09/13] net: axienet: Make missing MAC address non-fatal Robert Hancock
2019-05-31 21:16 ` Andrew Lunn
2019-06-03 13:22 ` David Laight
2019-06-03 15:49 ` Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 10/13] net: axienet: stop interface during shutdown Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 11/13] net: axienet: document axistream-connected attribute Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 12/13] net: axienet: make use of axistream-connected attribute optional Robert Hancock
2019-05-31 18:15 ` [PATCH net-next 13/13] net: axienet: convert to phylink API Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531211043.GD3154@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=John.Linn@xilinx$(echo .)com \
--cc=anirudh@xilinx$(echo .)com \
--cc=hancock@sedsystems$(echo .)ca \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox