From: Pavel Machek <pavel@denx•de>
To: Joel Fernandes <joel@joelfernandes•org>
Cc: Pavel Machek <pavel@denx•de>, LKML <linux-kernel@vger•kernel.org>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
Bjorn Helgaas <bhelgaas@google•com>,
Borislav Petkov <bp@alien8•de>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
"H. Peter Anvin" <hpa@zytor•com>, Ingo Molnar <mingo@redhat•com>,
Josh Triplett <josh@joshtriplett•org>,
Kees Cook <keescook@chromium•org>,
Kernel Hardening <kernel-hardening@lists•openwall.com>,
Lai Jiangshan <jiangshanlai@gmail•com>,
Len Brown <lenb@kernel•org>,
linux-acpi@vger•kernel.org, linux-pci@vger•kernel.org,
Linux PM <linux-pm@vger•kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios•com>,
Neil Brown <neilb@suse•com>, netdev <netdev@vger•kernel.org>,
Oleg Nesterov <oleg@redhat•com>,
"Paul E. McKenney" <paulmck@linux•ibm.com>,
Peter Zilstra <peterz@infradead•org>,
"Rafael J. Wysocki" <rjw@rjwysocki•net>,
rcu <rcu@vger•kernel.org>, Steven Rostedt <rostedt@goodmis•org>,
Tejun Heo <tj@kernel•org>, Thomas Gleixner <tglx@linutronix•de>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel•org>
Subject: Re: [RFC 2/6] ipv4: add lockdep condition to fix for_each_entry
Date: Mon, 3 Jun 2019 08:42:12 +0200 [thread overview]
Message-ID: <20190603064212.GA7400@amd> (raw)
In-Reply-To: <CAEXW_YSM2wwah2Q7LKmUO1Dp7GG62ciQA1nZ7GLw3m6cyuXXTw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On Sun 2019-06-02 08:24:35, Joel Fernandes wrote:
> On Sun, Jun 2, 2019 at 8:20 AM Joel Fernandes <joel@joelfernandes•org> wrote:
> >
> > On Sun, Jun 2, 2019 at 3:00 AM Pavel Machek <pavel@denx•de> wrote:
> > >
> > > On Sat 2019-06-01 18:27:34, Joel Fernandes (Google) wrote:
> > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes•org>
> > >
> > > This really needs to be merged to previous patch, you can't break
> > > compilation in middle of series...
> > >
> > > Or probably you need hlist_for_each_entry_rcu_lockdep() macro with
> > > additional argument, and switch users to it.
> >
> > Good point. I can also just add a temporary transition macro, and then
> > remove it in the last patch. That way no new macro is needed.
>
> Actually, no. There is no compilation break so I did not follow what
> you mean. The fourth argument to the hlist_for_each_entry_rcu is
> optional. The only thing that happens is new lockdep warnings will
> arise which later parts of the series fix by passing in that fourth
> argument.
Sorry, I missed that subtlety. Might be worth it enabling the lockdep
warning last in the series...
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-06-03 6:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 22:27 [RFC 0/6] Harden list_for_each_entry_rcu() and family Joel Fernandes (Google)
2019-06-01 22:27 ` [RFC 1/6] rcu: Add support for consolidated-RCU reader checking Joel Fernandes (Google)
2019-06-03 8:01 ` Peter Zijlstra
2019-06-03 14:18 ` Joel Fernandes
2019-06-03 19:42 ` Joel Fernandes
2019-06-04 10:53 ` Steven Rostedt
2019-06-04 17:48 ` Joel Fernandes
2019-06-04 14:01 ` Rasmus Villemoes
2019-06-04 23:57 ` Joel Fernandes
2019-06-01 22:27 ` [RFC 2/6] ipv4: add lockdep condition to fix for_each_entry Joel Fernandes (Google)
2019-06-02 7:00 ` Pavel Machek
2019-06-02 12:20 ` Joel Fernandes
2019-06-02 12:24 ` Joel Fernandes
2019-06-03 6:42 ` Pavel Machek [this message]
2019-06-03 12:28 ` Joel Fernandes
2019-06-01 22:27 ` [RFC 3/6] driver/core: Convert to use built-in RCU list checking Joel Fernandes (Google)
2019-06-01 22:27 ` [RFC 4/6] workqueue: Convert for_each_wq to use built-in list check Joel Fernandes (Google)
2019-06-05 1:24 ` Daniel Jordan
2019-06-05 13:04 ` Joel Fernandes
2019-06-01 22:27 ` [RFC 5/6] x86/pci: Pass lockdep condition to pcm_mmcfg_list iterator Joel Fernandes (Google)
2019-06-01 22:27 ` [RFC 6/6] acpi: Use built-in RCU list checking for acpi_ioremaps list Joel Fernandes (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603064212.GA7400@amd \
--to=pavel@denx$(echo .)de \
--cc=bhelgaas@google$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=jiangshanlai@gmail$(echo .)com \
--cc=joel@joelfernandes$(echo .)org \
--cc=josh@joshtriplett$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-hardening@lists$(echo .)openwall.com \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=neilb@suse$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oleg@redhat$(echo .)com \
--cc=paulmck@linux$(echo .)ibm.com \
--cc=peterz@infradead$(echo .)org \
--cc=rcu@vger$(echo .)kernel.org \
--cc=rjw@rjwysocki$(echo .)net \
--cc=rostedt@goodmis$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tj@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox