public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn•ch>
To: Vladimir Oltean <olteanv@gmail•com>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
	Vivien Didelot <vivien.didelot@gmail•com>,
	"David S. Miller" <davem@davemloft•net>,
	netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH v2 net 1/1] net: dsa: sja1105: Fix link speed not working at 100 Mbps and below
Date: Mon, 3 Jun 2019 15:06:54 +0200	[thread overview]
Message-ID: <20190603130654.GF17267@lunn.ch> (raw)
In-Reply-To: <CA+h21hoaOLassrEjHGoOortesCBkTUamCw8Efoc=vobwgwH25w@mail.gmail.com>

> Hi Andrew,
> 
> If I made the change you're suggesting, I would need to replace 0 with
> SPEED_UNKNOWN and thus I would conflict with this net-next change:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=af7cd0366ee994e8b35985d407261dc0ed9dfb4d
> 
> I think it's simpler to wait until Dave merges net into net-next and
> then submit this 1000 -> SPEED_1000 change as a net-next one, and let
> the fix itself go into net.
> Sounds ok?

Fine.

	Andrew

  reply	other threads:[~2019-06-03 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02 23:31 [PATCH v2 net 0/1] Fix link speed handling for SJA1105 DSA driver Vladimir Oltean
2019-06-02 23:31 ` [PATCH v2 net 1/1] net: dsa: sja1105: Fix link speed not working at 100 Mbps and below Vladimir Oltean
2019-06-03  0:50   ` Andrew Lunn
2019-06-03 13:04     ` Vladimir Oltean
2019-06-03 13:06       ` Andrew Lunn [this message]
2019-06-04 18:52   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603130654.GF17267@lunn.ch \
    --to=andrew@lunn$(echo .)ch \
    --cc=davem@davemloft$(echo .)net \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=olteanv@gmail$(echo .)com \
    --cc=vivien.didelot@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox