From: Andrew Lunn <andrew@lunn•ch>
To: Rasmus Villemoes <rasmus.villemoes@prevas•dk>
Cc: Vivien Didelot <vivien.didelot@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Rasmus Villemoes <Rasmus.Villemoes@prevas•se>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: fix comments and macro names in mv88e6390_g1_mgmt_rsvd2cpu
Date: Mon, 3 Jun 2019 15:22:06 +0200 [thread overview]
Message-ID: <20190603132206.GH3154@lunn.ch> (raw)
In-Reply-To: <20190603075236.18470-1-rasmus.villemoes@prevas.dk>
On Mon, Jun 03, 2019 at 07:52:46AM +0000, Rasmus Villemoes wrote:
> The macros have an extraneous '800' (after 0180C2 there should be just
> six nibbles, with X representing one), while the comments have
> interchanged c2 and 80 and an extra :00.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas•dk>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2019-06-03 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 7:52 [PATCH net-next] net: dsa: mv88e6xxx: fix comments and macro names in mv88e6390_g1_mgmt_rsvd2cpu Rasmus Villemoes
2019-06-03 13:22 ` Andrew Lunn [this message]
2019-06-03 17:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603132206.GH3154@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Rasmus.Villemoes@prevas$(echo .)se \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rasmus.villemoes@prevas$(echo .)dk \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox