Subject: Re: [PATCH][next][V2] bpf: remove redundant assignment to err

From: Jesper Dangaard Brouer <[email-masked]>
Date: Tue, 4 Jun 2019 13:58:57 +0200

On Tue,  4 Jun 2019 09:21:46 +0100
Colin King <[email-masked]> wrote:

> From: Colin Ian King <[email-masked]>
> 
> The variable err is assigned with the value -EINVAL that is never
> read and it is re-assigned a new value later on.  The assignment is
> redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email-masked]>
> 
> ---
> 
> V2: reorder variables as recommended by Jakub Kicinski to keep in
>     the networking code style.

Thank you for following the networking coding style.

Acked-by: Jesper Dangaard Brouer <[email-masked]>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer