From: "Michael S. Tsirkin" <mst@redhat•com>
To: Jason Wang <jasowang@redhat•com>
Cc: kvm@vger•kernel.org, virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
peterx@redhat•com, James.Bottomley@hansenpartnership•com,
hch@infradead•org, davem@davemloft•net, jglisse@redhat•com,
linux-mm@kvack•org, linux-arm-kernel@lists•infradead.org,
linux-parisc@vger•kernel.org, christophe.de.dinechin@gmail•com,
jrdr.linux@gmail•com
Subject: Re: [PATCH net-next 0/6] vhost: accelerate metadata access
Date: Wed, 5 Jun 2019 16:27:18 -0400 [thread overview]
Message-ID: <20190605162631-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190524081218.2502-1-jasowang@redhat.com>
On Fri, May 24, 2019 at 04:12:12AM -0400, Jason Wang wrote:
> Hi:
>
> This series tries to access virtqueue metadata through kernel virtual
> address instead of copy_user() friends since they had too much
> overheads like checks, spec barriers or even hardware feature
> toggling like SMAP. This is done through setup kernel address through
> direct mapping and co-opreate VM management with MMU notifiers.
>
> Test shows about 23% improvement on TX PPS. TCP_STREAM doesn't see
> obvious improvement.
>
> Thanks
Thanks this is queued for next.
Did you want to rebase and repost packed ring support on top?
IIUC it's on par with split ring with these patches.
> Changes from RFC V3:
> - rebase to net-next
> - Tweak on the comments
> Changes from RFC V2:
> - switch to use direct mapping instead of vmap()
> - switch to use spinlock + RCU to synchronize MMU notifier and vhost
> data/control path
> - set dirty pages in the invalidation callbacks
> - always use copy_to/from_users() friends for the archs that may need
> flush_dcache_pages()
> - various minor fixes
> Changes from V4:
> - use invalidate_range() instead of invalidate_range_start()
> - track dirty pages
> Changes from V3:
> - don't try to use vmap for file backed pages
> - rebase to master
> Changes from V2:
> - fix buggy range overlapping check
> - tear down MMU notifier during vhost ioctl to make sure
> invalidation request can read metadata userspace address and vq size
> without holding vq mutex.
> Changes from V1:
> - instead of pinning pages, use MMU notifier to invalidate vmaps
> and remap duing metadata prefetch
> - fix build warning on MIPS
>
> Jason Wang (6):
> vhost: generalize adding used elem
> vhost: fine grain userspace memory accessors
> vhost: rename vq_iotlb_prefetch() to vq_meta_prefetch()
> vhost: introduce helpers to get the size of metadata area
> vhost: factor out setting vring addr and num
> vhost: access vq metadata through kernel virtual address
>
> drivers/vhost/net.c | 4 +-
> drivers/vhost/vhost.c | 850 ++++++++++++++++++++++++++++++++++++------
> drivers/vhost/vhost.h | 38 +-
> 3 files changed, 766 insertions(+), 126 deletions(-)
>
> --
> 2.18.1
next prev parent reply other threads:[~2019-06-05 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 8:12 [PATCH net-next 0/6] vhost: accelerate metadata access Jason Wang
2019-05-24 8:12 ` [PATCH net-next 1/6] vhost: generalize adding used elem Jason Wang
2019-05-24 8:12 ` [PATCH net-next 2/6] vhost: fine grain userspace memory accessors Jason Wang
2019-05-24 8:12 ` [PATCH net-next 3/6] vhost: rename vq_iotlb_prefetch() to vq_meta_prefetch() Jason Wang
2019-05-24 8:12 ` [PATCH net-next 4/6] vhost: introduce helpers to get the size of metadata area Jason Wang
2019-05-24 8:12 ` [PATCH net-next 5/6] vhost: factor out setting vring addr and num Jason Wang
2019-05-24 8:12 ` [PATCH net-next 6/6] vhost: access vq metadata through kernel virtual address Jason Wang
2019-05-30 18:07 ` [PATCH net-next 0/6] vhost: accelerate metadata access David Miller
2019-05-30 18:13 ` Michael S. Tsirkin
2019-05-30 18:55 ` David Miller
2019-06-05 20:27 ` Michael S. Tsirkin [this message]
2019-06-10 3:50 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605162631-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=christophe.de.dinechin@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hch@infradead$(echo .)org \
--cc=jasowang@redhat$(echo .)com \
--cc=jglisse@redhat$(echo .)com \
--cc=jrdr.linux@gmail$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterx@redhat$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox