Subject: Re: [PATCH net] Revert "fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied"

From: Nathan Chancellor <[email-masked]>
Date: Wed, 5 Jun 2019 18:23:51 -0700

On Wed, Jun 05, 2019 at 05:55:26PM -0700, David Miller wrote:
> From: Hangbin Liu <[email-masked]>
> Date: Wed,  5 Jun 2019 12:27:14 +0800
> 
> > This reverts commit e9919a24d3022f72bcadc407e73a6ef17093a849.
> > 
> > Nathan reported the new behaviour breaks Android, as Android just add
> > new rules and delete old ones.
> > 
> > If we return 0 without adding dup rules, Android will remove the new
> > added rules and causing system to soft-reboot.
> > 
> > Reported-by: Nathan Chancellor <[email-masked]>
> > Fixes: e9919a24d302 ("fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied")
> > Signed-off-by: Hangbin Liu <[email-masked]>
> 
> Applied.

Please ensure this gets queued up for stable, as that is where I noticed
the issue.

Thank you for applying it,
Nathan