From: Andrew Lunn <andrew@lunn•ch>
To: Robert Hancock <hancock@sedsystems•ca>
Cc: netdev@vger•kernel.org, woojung.huh@microchip•com,
UNGLinuxDriver@microchip•com, vivien.didelot@gmail•com,
f.fainelli@gmail•com
Subject: Re: [PATCH net] net: dsa: microchip: Don't try to read stats for unused ports
Date: Wed, 12 Jun 2019 23:08:50 +0200 [thread overview]
Message-ID: <20190612210850.GD23695@lunn.ch> (raw)
In-Reply-To: <1560371612-31848-1-git-send-email-hancock@sedsystems.ca>
On Wed, Jun 12, 2019 at 02:33:32PM -0600, Robert Hancock wrote:
> If some of the switch ports were not listed in the device tree, due to
> being unused, the ksz_mib_read_work function ended up accessing a NULL
> dp->slave pointer and causing an oops. Skip checking statistics for any
> unused ports.
>
> Fixes: 7c6ff470aa867f53 ("net: dsa: microchip: add MIB counter reading
> support")
> Signed-off-by: Robert Hancock <hancock@sedsystems•ca>
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2019-06-12 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 20:33 [PATCH net] net: dsa: microchip: Don't try to read stats for unused ports Robert Hancock
2019-06-12 20:40 ` Vivien Didelot
2019-06-12 21:08 ` Andrew Lunn [this message]
2019-06-12 21:41 ` Florian Fainelli
2019-06-15 2:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612210850.GD23695@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hancock@sedsystems$(echo .)ca \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox