From: Andrew Lunn <andrew@lunn•ch>
To: Ioana Ciornei <ioana.ciornei@nxp•com>
Cc: linux@armlinux•org.uk, hkallweit1@gmail•com,
f.fainelli@gmail•com, davem@davemloft•net,
netdev@vger•kernel.org, alexandru.marginean@nxp•com,
ruxandra.radulescu@nxp•com
Subject: Re: [PATCH RFC 3/6] dpaa2-mac: add MC API for the DPMAC object
Date: Fri, 14 Jun 2019 03:12:24 +0200 [thread overview]
Message-ID: <20190614011224.GC28822@lunn.ch> (raw)
In-Reply-To: <1560470153-26155-4-git-send-email-ioana.ciornei@nxp.com>
> +/**
> + * dpmac_set_link_state() - Set the Ethernet link status
> + * @mc_io: Pointer to opaque I/O object
> + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
> + * @token: Token of DPMAC object
> + * @link_state: Link state configuration
> + *
> + * Return: '0' on Success; Error code otherwise.
> + */
> +int dpmac_set_link_state(struct fsl_mc_io *mc_io,
> + u32 cmd_flags,
> + u16 token,
> + struct dpmac_link_state *link_state)
> +{
> + struct dpmac_cmd_set_link_state *cmd_params;
> + struct fsl_mc_command cmd = { 0 };
> +
> + /* prepare command */
> + cmd.header = mc_encode_cmd_header(DPMAC_CMDID_SET_LINK_STATE,
> + cmd_flags,
> + token);
> + cmd_params = (struct dpmac_cmd_set_link_state *)cmd.params;
> + cmd_params->options = cpu_to_le64(link_state->options);
> + cmd_params->rate = cpu_to_le32(link_state->rate);
> + dpmac_set_field(cmd_params->state, STATE, link_state->up);
> + dpmac_set_field(cmd_params->state, STATE_VALID,
> + link_state->state_valid);
> + cmd_params->supported = cpu_to_le64(link_state->supported);
> + cmd_params->advertising = cpu_to_le64(link_state->advertising);
I don't understand what supported and advertising mean in the context
of a MAC. PHY yes, but MAC?
> + * DPMAC link configuration/state options
> + */
> +
> +/**
> + * Enable auto-negotiation
> + */
> +#define DPMAC_LINK_OPT_AUTONEG BIT_ULL(0)
> +/**
> + * Enable half-duplex mode
> + */
> +#define DPMAC_LINK_OPT_HALF_DUPLEX BIT_ULL(1)
> +/**
> + * Enable pause frames
> + */
> +#define DPMAC_LINK_OPT_PAUSE BIT_ULL(2)
> +/**
> + * Enable a-symmetric pause frames
> + */
> +#define DPMAC_LINK_OPT_ASYM_PAUSE BIT_ULL(3)
So is this to configure the MAC? The MAC can do half duplex, pause,
asym pause?
But from the previous patch, the PHY cannot do half duplex?
Andrew
next prev parent reply other threads:[~2019-06-14 1:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 23:55 [PATCH RFC 0/6] DPAA2 MAC Driver Ioana Ciornei
2019-06-13 23:55 ` [PATCH RFC 1/6] net: phy: update the autoneg state in phylink_phy_change Ioana Ciornei
2019-06-13 23:55 ` [PATCH RFC 2/6] dpaa2-eth: add support for new link state APIs Ioana Ciornei
2019-06-14 1:01 ` Andrew Lunn
2019-06-14 14:03 ` Ioana Ciornei
2019-06-13 23:55 ` [PATCH RFC 3/6] dpaa2-mac: add MC API for the DPMAC object Ioana Ciornei
2019-06-14 1:12 ` Andrew Lunn [this message]
2019-06-14 14:06 ` Ioana Ciornei
2019-06-17 14:28 ` Andrew Lunn
2019-06-13 23:55 ` [PATCH RFC 4/6] dpaa2-mac: add initial driver Ioana Ciornei
2019-06-14 1:42 ` Andrew Lunn
2019-06-14 9:50 ` Russell King - ARM Linux admin
2019-06-14 16:54 ` Ioana Ciornei
2019-06-14 17:03 ` Russell King - ARM Linux admin
2019-06-14 14:08 ` Ioana Ciornei
2019-06-14 10:20 ` Russell King - ARM Linux admin
2019-06-14 16:34 ` Ioana Ciornei
2019-06-13 23:55 ` [PATCH RFC 5/6] dpaa2-eth: add autoneg support Ioana Ciornei
2019-06-13 23:55 ` [PATCH RFC 6/6] net: documentation: add MAC/PHY proxy driver documentation Ioana Ciornei
2019-06-14 9:42 ` [PATCH RFC 0/6] DPAA2 MAC Driver Russell King - ARM Linux admin
2019-06-14 15:26 ` Ioana Ciornei
2019-06-17 14:46 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614011224.GC28822@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandru.marginean@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ruxandra.radulescu@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox