Subject: Re: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for configuration attributes.

From: Jiri Pirko <[email-masked]>
Date: Thu, 20 Jun 2019 15:37:48 +0200

Thu, Jun 20, 2019 at 02:09:29PM CEST, [email-masked] wrote:
>> -----Original Message-----
>> From: Jakub Kicinski <[email-masked]>
>> Sent: Tuesday, June 18, 2019 4:24 AM
>> To: Sudarsana Reddy Kalluru <[email-masked]>
>> Cc: [email-masked]; [email-masked]; Michal Kalderon
>> <[email-masked]>; Ariel Elior <[email-masked]>; Jiri Pirko
>> <[email-masked]>
>> Subject: [EXT] Re: [PATCH net-next 4/4] qed: Add devlink support for
>> configuration attributes.
>> 
>> External Email
>> 
>> ----------------------------------------------------------------------
>> On Mon, 17 Jun 2019 04:45:28 -0700, Sudarsana Reddy Kalluru wrote:
>> > This patch adds implementation for devlink callbacks for reading/
>> > configuring the device attributes.
>> >
>> > Signed-off-by: Sudarsana Reddy Kalluru <[email-masked]>
>> > Signed-off-by: Ariel Elior <[email-masked]>
>> 
>> You need to provide documentation for your parameters, plus some of them
>> look like they should potentially be port params, not device params.
>
>Thanks a lot for your review. Will add the required documentation. In case of Marvell adapter, any of the device/adapter/port parameters can be read/configurable via any PF (ethdev) on the port. Hence adding the commands at device level. Hope this is fine.

No it is not. Port param should be port param.

Also please be careful not to add any generic param as driver specific.

Thanks!