Subject: Re: [PATCH v2] flow_dissector: Fix vlan header offset in __skb_flow_dissect

From: Jiri Pirko <[email-masked]>
Date: Thu, 27 Jun 2019 09:44:55 +0200

Thu, Jun 27, 2019 at 04:28:29AM CEST, [email-masked] wrote:
>From: YueHaibing <[email-masked]>
>Date: Mon, 24 Jun 2019 11:49:13 +0800
>
>> @@ -998,6 +998,9 @@ bool __skb_flow_dissect(const struct net *net,
>>  		    skb && skb_vlan_tag_present(skb)) {
>>  			proto = skb->protocol;
>>  		} else {
>> +			if (dissector_vlan == FLOW_DISSECTOR_KEY_MAX)
>> +				nhoff -= sizeof(*vlan);
>> +
>
>But this is wrong when we are being called via eth_get_headlen(), in
>that case nhoff will be sizeof(struct ethhdr).

This patch was replaced by:
[PATCH] bonding: Always enable vlan tx offload
http://patchwork.ozlabs.org/patch/1122886/